Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740882 - dev-python/pytest-salt: RDEPEND on either app-admin/salt or www-servers/tornado
Summary: dev-python/pytest-salt: RDEPEND on either app-admin/salt or www-servers/tornado
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
: 702206 (view as bug list)
Depends on:
Blocks: 728612
  Show dependency tree
 
Reported: 2020-09-07 17:52 UTC by David Denoncin
Modified: 2021-07-11 23:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Denoncin 2020-09-07 17:52:07 UTC
Those packages are not listed in setup.py, but from utils/log_server_tornado.py

try:
    from salt.ext.tornado import gen
    from salt.ext.tornado.ioloop import IOLoop
    from salt.ext.tornado.tcpserver import TCPServer
    from salt.ext.tornado.iostream import StreamClosedError
except ImportError:
    from tornado import gen
    from tornado.ioloop import IOLoop
    from tornado.tcpserver import TCPServer
    from tornado.iostream import StreamClosedError

which leads to the following in a python console when dev-python/msgpack is installed but neither www-servers/tornado or app-admin/salt is installed:

>>> from pytestsalt.utils import log_server_tornado
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/pytestsalt/utils/log_server_tornado.py", line 18, in <module>
    from salt.ext.tornado import gen
ModuleNotFoundError: No module named 'salt'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/pytestsalt/utils/log_server_tornado.py", line 23, in <module>
    from tornado import gen
ModuleNotFoundError: No module named 'tornado'

This is solved by installing either www-servers/tornado or app-admin/salt for the relevant PYTHON_TARGETS.

Note: app-admin/salt and www-servers/tornado do not have the same PYTHON_TARGETS.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-01-19 17:38:59 UTC
Still hitting this.

It's commented out for some reason right now -- any reason?
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-11 22:59:19 UTC
*** Bug 702206 has been marked as a duplicate of this bug. ***
Comment 3 Larry the Git Cow gentoo-dev 2021-07-11 23:00:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c6373f480026fd01f163ee8fbb7c69d54a761cf

commit 5c6373f480026fd01f163ee8fbb7c69d54a761cf
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-07-11 22:59:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-07-11 23:00:32 +0000

    dev-python/pytest-salt: fix RDEPEND for salt/tornado
    
    Closes: https://bugs.gentoo.org/740882
    Signed-off-by: Sam James <sam@gentoo.org>

 ...-salt-2020.1.27-r2.ebuild => pytest-salt-2020.1.27-r3.ebuild} | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)