Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740872 - dev-python/pytest-salt: should RDEPEND on dev-python/msgpack
Summary: dev-python/pytest-salt: should RDEPEND on dev-python/msgpack
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-07 17:32 UTC by David Denoncin
Modified: 2021-02-06 21:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Denoncin 2020-09-07 17:32:27 UTC
dev-python/msgpack is not listed in setup.py, but from utils/log_server_tornado.py :

# Import 3rd-party libs
import msgpack

Which results in this in a python console:
>>> from pytestsalt.utils import log_server_tornado
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/pytestsalt/utils/log_server_tornado.py", line 15, in <module>
    import msgpack
ModuleNotFoundError: No module named 'msgpack'

I found this when testing dev-python/ordered-set with dev-python/pytest-salt installed trying to reproduce https://bugs.gentoo.org/740400.
Comment 1 Larry the Git Cow gentoo-dev 2021-02-06 21:47:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fac10158ee2d741265d510012bf6f8a41bb125a

commit 3fac10158ee2d741265d510012bf6f8a41bb125a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-06 21:43:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-06 21:47:06 +0000

    dev-python/pytest-salt: add missing dev-python/msgpack dep
    
    Closes: https://bugs.gentoo.org/740872
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{pytest-salt-2020.1.27.ebuild => pytest-salt-2020.1.27-r1.ebuild}    | 1 +
 1 file changed, 1 insertion(+)