Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740836 - app-emulation/qemu-9999 USE=sdl-image - src_configure(): ../meson.build:253:4: ERROR: Expected 1 arguments, got 2.
Summary: app-emulation/qemu-9999 USE=sdl-image - src_configure(): ../meson.build:253:4...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-07 08:05 UTC by Rafael Kitover
Modified: 2020-09-19 07:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge--info.txt,20.91 KB, text/plain)
2020-09-07 08:06 UTC, Rafael Kitover
Details
build.log (build.log.xz,5.31 KB, application/x-xz)
2020-09-07 08:06 UTC, Rafael Kitover
Details
meson.log (meson-log.txt.xz,2.08 KB, application/x-xz)
2020-09-07 08:06 UTC, Rafael Kitover
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Kitover 2020-09-07 08:05:51 UTC
../meson.build:253:4: ERROR: Expected 1 arguments, got 2.

[ebuild   R   *] app-emulation/qemu-9999::gentoo  USE="-accessibility aio alsa bzip2 caps capstone curl -debug -doc fdt filecaps -glusterfs -gnutls gtk -infiniband io-uring -iscsi -jack% -jemalloc jpeg lzo -multip
ath ncurses nfs nls numa opengl oss pin-upstream-blobs plugins png pulseaudio python -rbd -sasl sdl -sdl-image* seccomp (-selinux) slirp -smartcard snappy spice ssh -static -static-user systemtap tci -test usb usb
redir -vde vhost-net vhost-user-fs virgl virtfs vnc vte xattr xen -xfs xkb zstd" PYTHON_TARGETS="python3_6 python3_7 python3_8" QEMU_SOFTMMU_TARGETS="-aarch64 -alpha -arm -avr -cris -hppa -i386 -lm32 -m68k -microb
laze -microblazeel -mips -mips64 -mips64el -mipsel -moxie -nios2 -or1k -ppc -ppc64 -riscv32 -riscv64 -rx -s390x -sh4 -sh4eb -sparc -sparc64 -tricore -unicore32 x86_64 -xtensa -xtensaeb" QEMU_USER_TARGETS="-aarch64
 -aarch64_be -alpha -arm -armeb -cris -hppa -i386 -m68k -microblaze -microblazeel -mips -mips64 -mips64el -mipsel -mipsn32 -mipsn32el -nios2 -or1k -ppc -ppc64 -ppc64abi32 -ppc64le -riscv32 -riscv64 -s390x -sh4 -sh
4eb -sparc -sparc32plus -sparc64 -tilegx -x86_64 -xtensa -xtensaeb" 0 KiB  

Reproducible: Always
Comment 1 Rafael Kitover 2020-09-07 08:06:21 UTC
Created attachment 658938 [details]
emerge --info
Comment 2 Rafael Kitover 2020-09-07 08:06:37 UTC
Created attachment 658940 [details]
build.log
Comment 3 Rafael Kitover 2020-09-07 08:06:52 UTC
Created attachment 658942 [details]
meson.log
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2020-09-08 07:27:03 UTC
Looks like the failure here is missing 'sdl' flag when 'sdl-image' is requested, but error() call is invalid:

if sdl.found()
  # work around 2.0.8 bug
  sdl = declare_dependency(compile_args: '-Wno-undef',
                           dependencies: sdl)
  sdl_image = dependency('SDL2_image', required: get_option('sdl_image'),
                         method: 'pkg-config', static: enable_static)
else
  if get_option('sdl_image').enabled()
    error('sdl-image required, but SDL was @0@',
          get_option('sdl').disabled() ? 'disabled' : 'not found')
  endif
  sdl_image = not_found
endif
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2020-09-08 07:31:29 UTC
(In reply to Sergei Trofimovich from comment #4)
> Looks like the failure here is missing 'sdl' flag when 'sdl-image' is
> requested, but error() call is invalid:

>     error('sdl-image required, but SDL was @0@',
>           get_option('sdl').disabled() ? 'disabled' : 'not found')

https://mesonbuild.com/Reference-manual.html#error says it's a single-argument function. SHould use .format().
Comment 6 Larry the Git Cow gentoo-dev 2020-09-08 07:33:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3752d632441c34385ee7296126e3867536cb63e7

commit 3752d632441c34385ee7296126e3867536cb63e7
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-09-08 07:33:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-09-08 07:33:20 +0000

    app-emulation/qemu: tweak error message for missing SDL
    
    Reported-by: Rafael Kitover
    Bug: https://bugs.gentoo.org/740836
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-emulation/qemu/files/qemu-9999-format-error.patch | 14 ++++++++++++++
 app-emulation/qemu/qemu-9999.ebuild                   |  1 +
 2 files changed, 15 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2020-09-08 08:17:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ab61b9162819825424a6f30edb0a2d3290fd56f

commit 9ab61b9162819825424a6f30edb0a2d3290fd56f
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-09-08 08:17:36 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-09-08 08:17:48 +0000

    app-emulation/qemu: enable sdl-image only for softmmu
    
    qemu's build system became sightly stricter and disallows
    'sdl-image' support without 'sdl' support. The check only
    makes sense for softmmu build, but is done for all types of
    builds.
    
    The change disables 'sdl-image' flag for 'user' and 'tools'
    builds.
    
    Reported-by: Rafael Kitover
    Closes: https://bugs.gentoo.org/740836
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-emulation/qemu/qemu-9999.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Comment 8 Rafael Kitover 2020-09-18 23:49:08 UTC
Looks like the .format() fix was applied upstream and the patch can be removed.
Comment 9 Larry the Git Cow gentoo-dev 2020-09-19 07:33:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3ce8bbed78b0651008ec4c5e40df1de8e0f5052

commit b3ce8bbed78b0651008ec4c5e40df1de8e0f5052
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-09-19 07:31:53 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-09-19 07:33:01 +0000

    app-emulation/qemu: drop upstreamed patch
    
    This reverts commit 3752d632441c34385ee7296126e3867536cb63e7.
    
    Bug: https://bugs.gentoo.org/740836
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-emulation/qemu/files/qemu-9999-format-error.patch | 14 --------------
 app-emulation/qemu/qemu-9999.ebuild                   |  1 -
 2 files changed, 15 deletions(-)