Bug 740404 – =media-video/gpac-1.0.0: make: dh_link: No such file or directory

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lars Wendler (Polynomial-C) (RETIRED) 2020-09-04 18:49:55 UTC]

Created attachment 658412 [details]
build.log

dh_link /var/tmp/portage/media-video/gpac-1.0.0/image//usr/share/gpac/res/gpac.png /var/tmp/portage/media-video/gpac-1.0.0/image//usr/share/pixmaps/gpac.png    
make: dh_link: No such file or directory
make: *** [Makefile:147: install] Error 127
 * ERROR: media-video/gpac-1.0.0::gentoo failed (install phase):
 *   emake failed

[Comment 1 Steffen Kremser 2020-09-05 10:08:37 UTC]

i think the actual problem is a broken test in line  171 of "Makefile"

ifeq ($(IS_DEB_MAKE),undefined)
        ln -sf $(DESTDIR)$(prefix)/share/gpac/res/gpac.png $(DESTDIR)/usr/share/pixmaps/gpac.png
        $(INSTALL) $(INSTFLAGS) -m 644 $(SRC_PATH)/share/gpac.desktop "$(DESTDIR)/usr/share/applications/"
else
        dh_link $(DESTDIR)$(prefix)/share/gpac/res/gpac.png $(DESTDIR)$(prefix)/share/pixmaps/gpac.png
        $(INSTALL) $(INSTFLAGS) -m 644 $(SRC_PATH)/share/gpac.desktop "$(DESTDIR)$(prefix)/share/applications/"
endif

the "ifeq(,undefined)" seems to evaluate as false
.. thus entering the "this is debian, use dh_link" else block
.. thus failing with " dh_link: No such file or directory

replacing the test with 

ifeq ($(IS_DEB_MAKE),)

lets  "make install" work withouit hitting the error,
.. but i can't test whether that works on debian  8-/

[Comment 2 Benjamin Réveillé 2020-09-05 11:14:32 UTC]

Created attachment 658520 [details, diff]
not_IS_DEB_MAKE.patch

Here is the patch to put in /etc/portage/patches/media-video/gpac-1.0.0


IS_DEB_MAKE gets set to 1 in debian/rules which is used if "make deb" is done during build.

I'm guessing a previous version of gpac had a "IS_DEB_MAKE=undefined" at the start... or the previous test was ifndef IS_DEB_MAKE which was incorrectly changed...

[Comment 3 Steffen Kremser 2020-09-05 11:47:49 UTC]

looking at upstream, they are reworking their Makfiles anyway

https://github.com/gpac/gpac/blob/v1.0.0/Makefile   <--- has the broken test
https://github.com/gpac/gpac/blob/master/Makefile  <--- several changes ahead

where the special-casing of "png file symlink" in "install" target has been replaced by just

	$(INSTALL) $(INSTFLAGS) -m 644 $(SRC_PATH)/share/res/gpac.png "$(DESTDIR)$(prefix)/share/pixmaps/"

injecting the patch should tide us over until the next upstream release
(unless it is a "fix-some-unrelated-bug" on top of 1.0.0)

[Comment 4 Sam James 2020-09-08 22:24:49 UTC]

*** Bug 740432 has been marked as a duplicate of this bug. ***

[Comment 5 Larry the Git Cow 2020-09-08 22:42:57 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62238af1490e6900856b6f8fdd196ab779b46e72

commit 62238af1490e6900856b6f8fdd196ab779b46e72
Author:     Sam James <[e-mail]>
AuthorDate: 2020-09-08 22:30:23 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2020-09-08 22:42:45 +0000

    media-video/gpac: fix failed install for 1.0.0
    
    Upstream are currently rewriting huge amounts
    of their codebase. 0.8.x -> 1.0.0 marks a large change.
    
    In this process, they inadverently broke non-Debian
    builds by relying on "IS_DEB_MAKE" being set to
    'undefined'.
    
    We also change the openjpeg slot to :2 as per
    changing upstream requirements.
    
    Closes: https://bugs.gentoo.org/740404
    Bug: https://bugs.gentoo.org/735600
    Package-Manager: Portage-3.0.6, Repoman-3.0.1
    Signed-off-by: Sam James <[e-mail]>

 .../gpac/files/gpac-1.0.0-makefile-debian.patch    | 13 ++++++++++++
 media-video/gpac/gpac-1.0.0.ebuild                 | 24 ++++++++++++++--------
 2 files changed, 28 insertions(+), 9 deletions(-)