Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 739888 - net-libs/libwebsockets-4.0.20: stablereq
Summary: net-libs/libwebsockets-4.0.20: stablereq
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: CC-ARCHES, PullRequest
Depends on:
Blocks:
 
Reported: 2020-09-01 13:48 UTC by Jakov Smolić
Modified: 2020-09-08 17:02 UTC (History)
4 users (show)

See Also:
Package list:
net-libs/libwebsockets-4.0.20 arm64 net-libs/libhubbub-0.3.6 arm64 dev-libs/libparserutils-0.2.4-r1 arm64
Runtime testing required: ---
nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakov Smolić archtester gentoo-dev 2020-09-01 13:48:20 UTC 
Please stabilize. In tree since 2020-07-24. Thanks

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-01 18:18:29 UTC 
# cat libwebsockets-739888.report  | grep fail
USE='access-log caps -cgi client dbus -generic-sessions -http-proxy http2 -ipv6 -lejp -libev -libevent -libuv mbedtls -peer-limits server-status -smtp socks5 sqlite3 -ssl -static-libs -threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log caps -cgi client dbus -generic-sessions http-proxy -http2 ipv6 lejp libev -libevent libuv -mbedtls -peer-limits -server-status smtp socks5 sqlite3 ssl -static-libs -threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps -cgi client -dbus generic-sessions http-proxy http2 -ipv6 -lejp libev -libevent libuv mbedtls peer-limits -server-status smtp -socks5 sqlite3 -ssl static-libs -threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='access-log caps cgi client dbus -generic-sessions http-proxy http2 ipv6 lejp libev -libevent libuv mbedtls -peer-limits server-status -smtp -socks5 sqlite3 ssl static-libs -threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps cgi client dbus -generic-sessions -http-proxy -http2 -ipv6 lejp libev -libevent -libuv -mbedtls -peer-limits -server-status -smtp socks5 -sqlite3 -ssl -static-libs threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps cgi client dbus -generic-sessions -http-proxy http2 ipv6 -lejp libev -libevent -libuv mbedtls -peer-limits -server-status -smtp socks5 -sqlite3 ssl static-libs threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='access-log -caps cgi -client dbus -generic-sessions -http-proxy http2 ipv6 -lejp -libev -libevent -libuv mbedtls peer-limits -server-status -smtp -socks5 sqlite3 ssl static-libs threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='access-log caps -cgi -client dbus generic-sessions -http-proxy http2 -ipv6 -lejp -libev -libevent libuv -mbedtls -peer-limits server-status smtp socks5 sqlite3 -ssl -static-libs -threads zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps cgi client dbus -generic-sessions http-proxy -http2 ipv6 lejp libev -libevent -libuv mbedtls peer-limits -server-status -smtp -socks5 -sqlite3 -ssl static-libs -threads zip' failed for =net-libs/libwebsockets-4.0.20
USE='access-log -caps cgi -client dbus -generic-sessions -http-proxy http2 -ipv6 -lejp libev -libevent libuv -mbedtls -peer-limits -server-status smtp socks5 sqlite3 -ssl static-libs threads zip' failed for =net-libs/libwebsockets-4.0.20

:(
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-01 18:18:55 UTC 
I can report these as bugs but can you check if any of these are reproducible first, given the problems we've had with this package?
Comment 3 Jakov Smolić archtester gentoo-dev 2020-09-01 19:38:37 UTC 
Thanks, I reproduced all of these.
We were missing dbus dependency, and ssl USE conditionals were not clear.
I emerged it sucessfully with mentioned USE combinations, I think we should be good now
Comment 4 Larry the Git Cow gentoo-dev 2020-09-01 20:46:50 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ef7d3cec06c8af5d6ac93edb8ccae691d6aa965

commit 4ef7d3cec06c8af5d6ac93edb8ccae691d6aa965
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-09-01 19:28:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-09-01 20:46:34 +0000

    net-libs/libwebsockets: add dbus dependency, restrict ssl USE flags
    
    Depends on sys-apps/dbus is USE=dbus. Ensure that mbedtls
    cannot be set without ssl USE flag.
    
    Bug: https://bugs.gentoo.org/739888
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Closes: https://github.com/gentoo/gentoo/pull/17366
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/libwebsockets/libwebsockets-4.0.20.ebuild | 2 ++
 1 file changed, 2 insertions(+)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-02 00:44:39 UTC 
arm done
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-02 00:48:21 UTC 
(In reply to Jakov Smolic from comment #3)
> Thanks, I reproduced all of these.
> We were missing dbus dependency, and ssl USE conditionals were not clear.
> I emerged it sucessfully with mentioned USE combinations, I think we should
> be good now

This package is indeed a huge whack-a-mole which is why I stabled it for now but I'm going to really encourage you to trim down the USE flags for future because it's impossible to test them all :(

# cat libwebsockets-739888.report | grep fail
USE='-access-log caps cgi -client dbus -generic-sessions -http-proxy -http2 ipv6 -lejp libev -libevent libuv mbedtls -peer-limits server-status -smtp socks5 -sqlite3 ssl -static-libs -threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps cgi -client dbus generic-sessions -http-proxy -http2 -ipv6 lejp libev -libevent libuv -mbedtls peer-limits -server-status smtp socks5 sqlite3 ssl static-libs threads -zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps -cgi client dbus generic-sessions -http-proxy -http2 -ipv6 -lejp -libev -libevent libuv -mbedtls peer-limits server-status smtp -socks5 sqlite3 -ssl -static-libs -threads zip' failed for =net-libs/libwebsockets-4.0.20
USE='-access-log -caps cgi client dbus -generic-sessions http-proxy -http2 ipv6 -lejp libev -libevent -libuv -mbedtls peer-limits -server-status -smtp socks5 -sqlite3 ssl -static-libs -threads zip' failed for =net-libs/libwebsockets-4.0.20
Comment 7 Jakov Smolić archtester gentoo-dev 2020-09-02 11:32:15 UTC 
(In reply to Sam James from comment #6)
> (In reply to Jakov Smolic from comment #3)
> > Thanks, I reproduced all of these.
> > We were missing dbus dependency, and ssl USE conditionals were not clear.
> > I emerged it sucessfully with mentioned USE combinations, I think we should
> > be good now
> 
> This package is indeed a huge whack-a-mole which is why I stabled it for now
> but I'm going to really encourage you to trim down the USE flags for future
> because it's impossible to test them all :(

Thank you for the effort, I am aware that it's a big hassle to test this package. I will try to reduce the USE flag complexity on the next version bump to make things easier.

> # cat libwebsockets-739888.report | grep fail
> USE='-access-log caps cgi -client dbus -generic-sessions -http-proxy -http2
> ipv6 -lejp libev -libevent libuv mbedtls -peer-limits server-status -smtp
> socks5 -sqlite3 ssl -static-libs -threads -zip' failed for
> =net-libs/libwebsockets-4.0.20
> USE='-access-log -caps cgi -client dbus generic-sessions -http-proxy -http2
> -ipv6 lejp libev -libevent libuv -mbedtls peer-limits -server-status smtp
> socks5 sqlite3 ssl static-libs threads -zip' failed for
> =net-libs/libwebsockets-4.0.20
> USE='-access-log -caps -cgi client dbus generic-sessions -http-proxy -http2
> -ipv6 -lejp -libev -libevent libuv -mbedtls peer-limits server-status smtp
> -socks5 sqlite3 -ssl -static-libs -threads zip' failed for
> =net-libs/libwebsockets-4.0.20
> USE='-access-log -caps cgi client dbus -generic-sessions http-proxy -http2
> ipv6 -lejp libev -libevent -libuv -mbedtls peer-limits -server-status -smtp
> socks5 -sqlite3 ssl -static-libs -threads zip' failed for
> =net-libs/libwebsockets-4.0.20

btw I'm not able to reproduce this. I just left my PC emerging libwebsockets for a few hours with different combinations, and I wasn't able to reproduce these. Do you happen to have logs for these?

# grep succeeded lws.report | wc -l
544

# grep failed lws.report | wc -l
0
Comment 8 Thomas Deutschmann (RETIRED) gentoo-dev 2020-09-03 14:30:30 UTC 
x86 stable
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-05 02:38:15 UTC 
amd64 done

all arches done
Comment 10 Jakov Smolić archtester gentoo-dev 2020-09-08 10:24:25 UTC 
arm64 please, thanks.
Comment 11 NATTkA bot gentoo-dev 2020-09-08 10:24:51 UTC 
Sanity check failed:

> net-libs/libwebsockets-4.0.20
>   depend arm64 stable profile default/linux/arm64/17.0 (9 total)
>     net-libs/libhubbub
>   rdepend arm64 stable profile default/linux/arm64/17.0 (9 total)
>     net-libs/libhubbub
Comment 12 NATTkA bot gentoo-dev 2020-09-08 10:28:51 UTC 
Sanity check failed:

> net-libs/libhubbub-0.3.6
>   depend arm64 stable profile default/linux/arm64/17.0 (9 total)
>     dev-libs/libparserutils:=
>   rdepend arm64 stable profile default/linux/arm64/17.0 (9 total)
>     dev-libs/libparserutils:=
Comment 13 NATTkA bot gentoo-dev 2020-09-08 10:32:52 UTC 
All sanity-check issues have been resolved
Comment 14 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-08 17:02:40 UTC 
arm64 done

all arches done