Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 739340 - net-libs/nodejs - restore LTS versions
Summary: net-libs/nodejs - restore LTS versions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-28 01:38 UTC by Tomáš Mózes
Modified: 2020-09-21 08:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2020-08-28 01:38:29 UTC
Can we please at least restore the latest 10.x and 12.x from https://github.com/gentoo/gentoo/commit/da795fc618b5ea34652ca7426a025230fbe9d663 ? We don't have any LTS version in Gentoo right now.

10.x and 12.x are going to be supported for 6 and 18 months, so is there any reason to drop them? Kibana for example still uses node 10.x.

Thanks.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-08-28 07:32:01 UTC
(In reply to Tomáš Mózes from comment #0)
> We don't have any LTS version in  Gentoo right now.

Why is that a problem?

> 10.x and 12.x are going to be supported for 6 and 18 months, so is there any
> reason to drop them?

1) Nothing depended on them.

2) I haven't updated the 12 branch since May 2020 and exactly nobody asked for an LTS version bump.

3) I haven't updated the 10 branch since April 2020 and exactly nobody asked for an LTS version bump.

4) The 10 branch required python2_7 to build.

> Kibana for example still uses node 10.x.

kibana-bin-6.8.11.ebuild : RDEPEND -=- >=net-libs/nodejs-10.15.2
 kibana-bin-7.8.1.ebuild : RDEPEND -=- >=net-libs/nodejs-10.21.0

That doesn't say it is not supported by greater branches.
Comment 2 Tomáš Mózes 2020-08-28 07:57:11 UTC
(In reply to Jeroen Roovers from comment #1)
> (In reply to Tomáš Mózes from comment #0)
> > We don't have any LTS version in  Gentoo right now.
> 
> Why is that a problem?

Applications we use are still stick on Node 10.x. Just tested them on Node 12.x, but it failed :( Sadly not every project is on the latest and greatest Node :(

> 
> > 10.x and 12.x are going to be supported for 6 and 18 months, so is there any
> > reason to drop them?
> 
> 1) Nothing depended on them.

And if you have applications running on your server? On a building machine maybe? That information cannot be in portage.

> 
> 2) I haven't updated the 12 branch since May 2020 and exactly nobody asked
> for an LTS version bump.

Maybe if it just works, nobody asked. I can do the version bump.

> 
> 3) I haven't updated the 10 branch since April 2020 and exactly nobody asked
> for an LTS version bump.
> 
> 4) The 10 branch required python2_7 to build.

Ok that may be a good argument to drop it, but sadly I still use it.

> 
> > Kibana for example still uses node 10.x.
> 
> kibana-bin-6.8.11.ebuild : RDEPEND -=- >=net-libs/nodejs-10.15.2
>  kibana-bin-7.8.1.ebuild : RDEPEND -=- >=net-libs/nodejs-10.21.0
> 
> That doesn't say it is not supported by greater branches.

We also have a warning in the ebuild:
https://github.com/gentoo/gentoo/blob/master/www-apps/kibana-bin/kibana-bin-7.8.1.ebuild#L82

because we had breakage on versions other than recommended by upstream:
https://github.com/elastic/kibana/blob/master/package.json#L485
Comment 3 Jan Henke 2020-08-28 10:06:16 UTC
I require a nodejs 12.x for my work, as said many applications have not been ported to 14.x yet. As long as upstream supports these versions, I would really be very useful to have an ebuild lying around.

Going from one major release to the next is always something that requires planning and engineering resources, so it is not always done right away after a new major version of nodejs is released. Also since upstream provides LTS support for these branches, it is not easy to get these resources right away.

NodeJS is a package that is not just a dependency for other ebuilds, but often required on it's own. My day to day job simply requires it. So even if there are no other in-tree consumers of these specific versions, I as a use need those.

I am aware that maintainer resources are also very limited, but I would kindly ask for an important package like NodeJS to keep an ebuild for every LTS branch as long as upstream supports it. It really would help a lot.
Comment 4 Stephen Bosch 2020-09-03 14:53:38 UTC
(In reply to Jeroen Roovers from comment #1)
> (In reply to Tomáš Mózes from comment #0)
> > We don't have any LTS version in  Gentoo right now.
> 
> Why is that a problem?

There are widely-deployed applications like Ghost (https://ghost.org/faq/node-versions/) that rely on LTS versions.

LTS versions are per definitionem supported by upstream, so it's not like we're trying to keep alive something that's dead here.
Comment 5 Larry the Git Cow gentoo-dev 2020-09-04 07:09:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eda2daf31ca9729e117cdf8ada5c3ac90fc20780

commit eda2daf31ca9729e117cdf8ada5c3ac90fc20780
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-09-04 07:03:41 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-09-04 07:09:38 +0000

    net-libs/nodejs: Restore some of the 12.x.x branch
    
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    RepoMan-Options: --force
    Bug: https://bugs.gentoo.org/726836
    Bug: https://bugs.gentoo.org/739340
    Closes: https://bugs.gentoo.org/740218
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-libs/nodejs/Manifest                           |   2 +
 net-libs/nodejs/files/nodejs-99999999-llhttp.patch |  20 ++
 net-libs/nodejs/nodejs-12.16.1.ebuild              | 213 +++++++++++++++++++++
 net-libs/nodejs/nodejs-12.18.3.ebuild              | 213 +++++++++++++++++++++
 4 files changed, 448 insertions(+)
Comment 6 Tomáš Mózes 2020-09-04 07:43:14 UTC
Can we please also add 10.22.0? I've just copied the previous ebuild and it works fine. Enough if we have the latest version (in ~arch). Thanks for 12.x too.
Comment 7 Larry the Git Cow gentoo-dev 2020-09-16 07:40:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=224ae61f77174ca30c1424737cdacd821c623789

commit 224ae61f77174ca30c1424737cdacd821c623789
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-09-16 07:39:36 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-09-16 07:40:17 +0000

    net-libs/nodejs: Versions 10.19.0 10.22.1
    
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    RepoMan-Options: --force
    Bug: https://bugs.gentoo.org/742893
    Closes: https://bugs.gentoo.org/739340
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-libs/nodejs/Manifest              |   2 +
 net-libs/nodejs/nodejs-10.19.0.ebuild | 205 ++++++++++++++++++++++++++++++++++
 net-libs/nodejs/nodejs-10.22.1.ebuild | 205 ++++++++++++++++++++++++++++++++++
 3 files changed, 412 insertions(+)
Comment 8 Tomáš Mózes 2020-09-16 17:21:37 UTC
Thanks
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-19 13:20:07 UTC
commit d7fefb6db4128b66ad842f43c8f6d24da43b8486
Author: Michał Górny <mgorny@gentoo.org>
Date:   Sat Sep 19 13:20:58 2020 +0200

    net-libs/nodejs: Remove old

    Signed-off-by: Michał Górny <mgorny@gentoo.org>


I have no idea what is going on here.
Comment 10 Tomáš Mózes 2020-09-21 06:05:51 UTC
(In reply to Jeroen Roovers from comment #9)
> commit d7fefb6db4128b66ad842f43c8f6d24da43b8486
> Author: Michał Górny <mgorny@gentoo.org>
> Date:   Sat Sep 19 13:20:58 2020 +0200
> 
>     net-libs/nodejs: Remove old
> 
>     Signed-off-by: Michał Górny <mgorny@gentoo.org>
> 
> 
> I have no idea what is going on here.

I understand we are getting rid of python 2 stuff, but this supported Nodejs version only needs python 2 itself for building, it's not used as a dependency of others. It would be great to revert this commit and restore nodejs 10.x until it's supported (6 months) or until we actually drop python 2 from portage. Thanks
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-21 06:09:09 UTC
If they don't have other python deps, I suppose we can do it.  For another 3 months.
Comment 12 Tomáš Mózes 2020-09-21 08:30:38 UTC
(In reply to Michał Górny from comment #11)
> If they don't have other python deps, I suppose we can do it.  For another 3
> months.

Cool, thanks.