Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 739186 - games-engines/odamex-0.8.3 fails to compile
Summary: games-engines/odamex-0.8.3 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Breathitt Gray
URL:
Whiteboard:
Keywords: PullRequest
: 739226 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-27 05:17 UTC by Agostino Sarubbo
Modified: 2020-08-27 21:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,6.83 KB, text/plain)
2020-08-27 05:17 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-08-27 05:17:45 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-engines/odamex-0.8.3 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.
Comment 1 Agostino Sarubbo gentoo-dev 2020-08-27 05:17:47 UTC
Created attachment 656992 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-08-27 11:23:56 UTC
*** Bug 739226 has been marked as a duplicate of this bug. ***
Comment 3 William Breathitt Gray 2020-08-27 16:40:09 UTC
The line endings for this patch got clobbered some how. I'm not really sure why, but I'll submit a new PR with the correct line endings.
Comment 4 Larry the Git Cow gentoo-dev 2020-08-27 17:46:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=493793045415865eb892c7ee5c4efb6c603d338f

commit 493793045415865eb892c7ee5c4efb6c603d338f
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2020-08-27 16:41:28 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-08-27 17:46:26 +0000

    games-engines/odamex: Fix line endings in odalaunch patch
    
    Closes: https://bugs.gentoo.org/739186
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/17283
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../odamex-0.8.3-Use-C-11-on-odalaunch-target-for-wx-3.0.4-and-up.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 William Breathitt Gray 2020-08-27 20:46:03 UTC
(In reply to Larry the Git Cow from comment #4)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=493793045415865eb892c7ee5c4efb6c603d338f
> 
> commit 493793045415865eb892c7ee5c4efb6c603d338f
> Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
> AuthorDate: 2020-08-27 16:41:28 +0000
> Commit:     James Le Cuirot <chewi@gentoo.org>
> CommitDate: 2020-08-27 17:46:26 +0000
> 
>     games-engines/odamex: Fix line endings in odalaunch patch
>     
>     Closes: https://bugs.gentoo.org/739186
>     Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>     Closes: https://github.com/gentoo/gentoo/pull/17283
>     Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> 
>  .../odamex-0.8.3-Use-C-11-on-odalaunch-target-for-wx-3.0.4-and-up.patch | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The line ending changes were missed again.
Comment 6 Larry the Git Cow gentoo-dev 2020-08-27 21:09:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de70754fe00d527a888c54e5110aed9d6730df57

commit de70754fe00d527a888c54e5110aed9d6730df57
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2020-08-27 21:08:46 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-08-27 21:08:46 +0000

    games-engines/odamex: Try to fix patch line endings issue again
    
    Closes: https://bugs.gentoo.org/739186
    Closes: https://github.com/gentoo/gentoo/pull/17283
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 ...1-on-odalaunch-target-for-wx-3.0.4-and-up.patch | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)