Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 738904 - games-fps/eduke3[demo] has circular dependency with games-fps/duke3d-demodata
Summary: games-fps/eduke3[demo] has circular dependency with games-fps/duke3d-demodata
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-25 06:26 UTC by BT
Modified: 2020-08-25 21:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,6.06 KB, text/plain)
2020-08-25 06:26 UTC, BT
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2020-08-25 06:26:48 UTC
Created attachment 656572 [details]
emerge --info

# emerge eduke32

These are the packages that would be merged, in order:

Calculating dependencies... done!


[nomerge       ] games-fps/eduke32-20200808.9208::gentoo  USE="demo flac opengl png vorbis -cdinstall -fluidsynth -gtk -hrp -offensive -opl -psx -sc-55 -sdk -server -timidity -tools -voxels -vpx -xmp" 
[ebuild  N    ~]  games-fps/duke3d-demodata-1.3::gentoo  0 KiB
[ebuild  N    ~]   games-fps/eduke32-20200808.9208::gentoo  USE="demo flac opengl png vorbis -cdinstall -fluidsynth -gtk -hrp -offensive -opl -psx -sc-55 -sdk -server -timidity -tools -voxels -vpx -xmp" 19,329 KiB

Total: 2 packages (2 new), Size of downloads: 19,329 KiB

 * Error: circular dependencies:

(games-fps/duke3d-demodata-1.3:0/0::gentoo, ebuild scheduled for merge) depends on
 (games-fps/eduke32-20200808.9208:0/0::gentoo, ebuild scheduled for merge) (runtime)
  (games-fps/duke3d-demodata-1.3:0/0::gentoo, ebuild scheduled for merge) (buildtime)

It might be possible to break this cycle
by applying the following change:
- games-fps/eduke32-20200808.9208 (Change USE: -demo)

Note that this change can be reverted, once the package has been installed.


Does games-fps/duke3d-demodata really need to have a RDEPEND on games-fps/eduke32 ? Data packages for quake1 and quake2 don't have such a dependency.

Another issue is the SRC_URI for the demo data will timeout and has so for the past few weeks I have tried it. Instead I got the demo data from another site[1] and the sha512 hash matches the Manifest.

[1] http://dnr.duke4.net/shareware.php.html
Comment 1 Conrad Kostecki gentoo-dev 2020-08-25 21:57:21 UTC
(In reply to BT from comment #0)
> Does games-fps/duke3d-demodata really need to have a RDEPEND on
> games-fps/eduke32 ? Data packages for quake1 and quake2 don't have such a
> dependency.

Yes and no. It's used by runtime and uses eduke32 as runtime. But the circular dependencies can be fixed by using PDEPEND. That means, duke3d-data or duke3d-demodata don't need to be installed in prior, thus breaking the circular dependencies.
 
> Another issue is the SRC_URI for the demo data will timeout and has so for
> the past few weeks I have tried it. Instead I got the demo data from another
> site[1] and the sha512 hash matches the Manifest.
> 
> [1] http://dnr.duke4.net/shareware.php.html

Will change it.

Thanks!
Comment 2 Larry the Git Cow gentoo-dev 2020-08-25 21:59:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49efc4f59a2d415d58201bcf9c7e857cbff29f95

commit 49efc4f59a2d415d58201bcf9c7e857cbff29f95
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-08-25 21:21:37 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-08-25 21:59:26 +0000

    games-fps/eduke32: bump to version 20200824.9249
    
    Closes: https://bugs.gentoo.org/738904
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 games-fps/eduke32/Manifest                     |   1 +
 games-fps/eduke32/eduke32-20200824.9249.ebuild | 229 +++++++++++++++++++++++++
 2 files changed, 230 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85036cd7c18fb9c0d9024eeadfc8f21e73913c34

commit 85036cd7c18fb9c0d9024eeadfc8f21e73913c34
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-08-25 21:26:20 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-08-25 21:59:28 +0000

    games-fps/duke3d-demodata: update SRC_URI
    
    It seems, that 3DRealms FTP mirror is gone forever..
    So switching to an alternative link. File matches distfiles.
    
    Bug: https://bugs.gentoo.org/738904
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 games-fps/duke3d-demodata/duke3d-demodata-1.3.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)