Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 738094 - app-misc/todo-2.12.0 version bump
Summary: app-misc/todo-2.12.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrice Clement
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-08-20 03:05 UTC by bugs
Modified: 2020-09-29 11:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bugs 2020-08-20 03:05:00 UTC
A new version 2.12.0 seems to be available. Please update to latest release.
Comment 1 Larry the Git Cow gentoo-dev 2020-09-16 20:50:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b00b41ce1d62df911bec838b336b1d3cff142ea6

commit b00b41ce1d62df911bec838b336b1d3cff142ea6
Author:     Patrice Clement <monsieurp@gentoo.org>
AuthorDate: 2020-09-16 20:49:29 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2020-09-16 20:49:29 +0000

    app-misc/todo: version bump.
    
    Closes: https://bugs.gentoo.org/738094
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 app-misc/todo/Manifest           |  1 +
 app-misc/todo/todo-2.12.0.ebuild | 66 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
Comment 2 Ferenc Erki 2020-09-29 09:47:48 UTC
Hmm, looks like this bump and the subsequent cleanup of the oldest version was incomplete compared to the related PR. The leftover old patch file has already been cleaned up separately, but it seems the command alias behavior is inconsistent with previous versions now.

We still install the `todotxt` and `todocli` command aliases for `todo.sh`, but we dropped the related patch file, so there's complaints about missing completions during installation. Currently it's unclear for me if this is just an oversight, or if we actively would like to drop the aliases completely (or partially, e.g. just the bash completions for them).

I've left a longer comment about this on the PR itself as well: https://github.com/gentoo/gentoo/pull/17270#issuecomment-700585146

I think the changes from the PR can still be merged/cherry-picked, but I can also send a new PR with the desired changes. In the latter case, please advise how to proceed with the aliases (preserve, drop partially, drop completely, etc.).
Comment 3 Patrice Clement gentoo-dev 2020-09-29 10:21:02 UTC
Hi Ferenc

Sorry for ignoring your PR, it was unintentional: I went through a massive list of version bumps and forgot to take into consideration potential PRs for a few packages. Apologies.

Please file a new PR and I will take care of merging it properly this time around. Don't hesitate to nudge me on IRC or via email! ;)

Thanks!
Comment 4 Ferenc Erki 2020-09-29 11:33:39 UTC
(In reply to Patrice Clement from comment #3)
> Sorry for ignoring your PR, it was unintentional: I went through a massive
> list of version bumps and forgot to take into consideration potential PRs
> for a few packages. Apologies.

No worries, mistakes happen, and we have these forums to discuss and resolve situations like this ;)

> Please file a new PR and I will take care of merging it properly this time
> around. Don't hesitate to nudge me on IRC or via email! ;)

Alright, I'll rebase my version on top of current master branch, and will open a new PR.