Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 737596 - media-gfx/inkscape-1.0-r1: src/ui/tool/node.cpp:100:25: error: field ‘rel_error’ has incomplete type ‘std::atomic<double>’
Summary: media-gfx/inkscape-1.0-r1: src/ui/tool/node.cpp:100:25: error: field ‘rel_err...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-08-17 08:04 UTC by Zoltan Puskas
Modified: 2020-08-26 06:49 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix_atomic_rel_error.patch (fix_atomic.patch,319 bytes, patch)
2020-08-17 23:38 UTC, ZappeL
Details | Diff
build.log (build.log.xz,24.78 KB, application/x-xz)
2020-08-18 07:02 UTC, Zoltan Puskas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Puskas 2020-08-17 08:04:43 UTC
Build failure.

Reproducible: Always




$ emerge --info media-gfx/inkscape
Portage 3.0.2 (python 3.7.8-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-9.3.0, glibc-2.32, 5.7.8-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.7.8-gentoo-x86_64-Intel-R-_Core-TM-_i7-8550U_CPU_@_1.80GHz-with-gentoo-2.7
KiB Mem:    32845144 total,   2437836 free
KiB Swap:    2097128 total,   2096616 free
Timestamp of repository gentoo: Sun, 16 Aug 2020 08:30:01 +0000
Head commit of repository gentoo: b2864f38d6673ae1cf6ccf8b741db22955980458
Head commit of repository sinustrom: c90e12390903717ab07571e70c12815cf3ee3ac3

sh bash 5.0_p18
ld GNU ld (Gentoo 2.34 p6) 2.34.0
distcc 3.3.3 x86_64-pc-linux-gnu [enabled]
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r1::gentoo, 3.6.11-r2::gentoo, 3.7.8-r2::gentoo, 3.8.5::gentoo, 3.9.0_rc1::gentoo
dev-util/cmake:           3.18.1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.34-r2::gentoo
sys-devel/gcc:            8.4.0-r1::gentoo, 9.3.0-r1::gentoo
sys-devel/gcc-config:     2.3.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.8::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://lambda/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

sinustrom-test
    location: /var/db/repos/sinustrom-test
    masters: gentoo

sinustrom
    location: /var/lib/layman/sinustrom
    sync-type: git
    sync-uri: https://github.com/zpuskas/sinustrom-gentoo-overlay.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=broadwell -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mno-sse4a -mcx16 -msahf -mmovbe -maes -mno-sha -mpclmul -mpopcnt -mabm -mno-lwp -mfma -mno-fma4 -mno-xop -mbmi -msgx -mbmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mno-rtm -mno-hle -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mno-avx512f -mno-avx512er -mno-avx512cd -mno-avx512pf -mno-prefetchwt1 -mclflushopt -mxsavec -mxsaves -mno-avx512dq -mno-avx512bw -mno-avx512vl -mno-avx512ifma -mno-avx512vbmi -mno-avx5124fmaps -mno-avx5124vnniw -mno-clwb -mno-mwaitx -mno-clzero -mno-pku -mno-rdpid --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192 -mtune=generic -O3 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=broadwell -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mno-sse4a -mcx16 -msahf -mmovbe -maes -mno-sha -mpclmul -mpopcnt -mabm -mno-lwp -mfma -mno-fma4 -mno-xop -mbmi -msgx -mbmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mno-rtm -mno-hle -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mno-avx512f -mno-avx512er -mno-avx512cd -mno-avx512pf -mno-prefetchwt1 -mclflushopt -mxsavec -mxsaves -mno-avx512dq -mno-avx512bw -mno-avx512vl -mno-avx512ifma -mno-avx512vbmi -mno-avx5124fmaps -mno-avx5124vnniw -mno-clwb -mno-mwaitx -mno-clzero -mno-pku -mno-rdpid --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192 -mtune=generic -O3 -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup collision-protect config-protect-if-modified distcc distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="rsync://lambda/gentoo-distfiles http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
MAKEOPTS="-j96 -l8"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups dbus declarative dri dts dvd dvdr emboss encode exif f16c flac fma3 fortran gdbm gif gphoto2 gpm gtk hardened iconv icu ipv6 jpeg jpeg2k kde kipi kwallet lcms ldap libglvnd libnotify libtirpc lm_sensors lzma mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opencl opengl openmp pam pango pclmul pcre pdf phonon plasma png policykit popcnt posix ppds pulseaudio qml qt5 readline sdl seccomp smp spell split-usr sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 startup-notification svg systemd tcpd threads tiff truetype udev udisks unicode upower usb uxa vaapi vim-syntax vorbis widgets wifi wxwidgets x264 xattr xcb xml xpm xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="hda-intel usb-audio" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput wacom synaptics joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="alsa_usb" LLVM_TARGETS="x86 BPF" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7 python3_8" QEMU_SOFTMMU_TARGETS="x86_64 arm aarch64" QEMU_USER_TARGETS="x86_64 arm aarch64" RUBY_TARGETS="ruby26 ruby27" SANE_BACKENDS="plustek genesys" USERLAND="GNU" VIDEO_CARDS="intel i965 nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Zoltan Puskas 2020-08-17 08:06:38 UTC
From the build.log the relevant section:

/tmp/portage/media-gfx/inkscape-1.0-r1/work/inkscape-1.0_2020-05-01_4035a4fb49/src/ui/tool/node.cpp:100:25: error: field ‘rel_error’ has incomplete type ‘std::atomic<double>’
  100 |     std::atomic<double> rel_error; /// Cached relative error
      |                         ^~~~~~~~~
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/g++-v9/bits/shared_ptr_atomic.h:33,                                                                                                                                                                                                                                                 from /usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/g++-v9/memory:82,                                                                                                                                                                                                                                                                   from /tmp/portage/media-gfx/inkscape-1.0-r1/work/inkscape-1.0_2020-05-01_4035a4fb49/src/preferences.h:21,
                 from /tmp/portage/media-gfx/inkscape-1.0-r1/work/inkscape-1.0_2020-05-01_4035a4fb49/src/desktop.h:33,
                 from /tmp/portage/media-gfx/inkscape-1.0-r1/work/inkscape-1.0_2020-05-01_4035a4fb49/src/ui/tool/node.cpp:19:
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/g++-v9/bits/atomic_base.h:145:12: note: declaration of ‘struct std::atomic<double>’
  145 |     struct atomic;                                                                                                                                                                                                                                                                                                                    |            ^~~~~~
Comment 2 Jonas Stein gentoo-dev 2020-08-17 19:09:47 UTC
Thank you for the report. We need to have all information at hand before ticket assignment. That is why I ask you to 
* attach the logs and 
* paste the emerge info 
as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Comment 3 ZappeL 2020-08-17 23:38:32 UTC
Created attachment 655182 [details, diff]
fix_atomic_rel_error.patch
Comment 4 Jonas Stein gentoo-dev 2020-08-18 04:53:00 UTC
is upstream aware of this patch? Please link to the ticket, if there is one.
Comment 5 Zoltan Puskas 2020-08-18 07:02:27 UTC
Created attachment 655190 [details]
build.log
Comment 6 Zoltan Puskas 2020-08-18 07:08:47 UTC
Upstream issue: https://gitlab.com/inkscape/inbox/-/issues/3417
Comment 7 Zoltan Puskas 2020-08-18 07:18:32 UTC
Patch works, inkscape compiles and runs properly.
Comment 8 Zoltan Puskas 2020-08-18 08:21:16 UTC
I've commented on upstream's issue and also attached zappel's patch.
Comment 9 Rémi Cardona (RETIRED) gentoo-dev 2020-08-25 05:18:21 UTC
I hit this too, mind if I commit this?

Cheers
Comment 10 Zoltan Puskas 2020-08-25 13:55:43 UTC
It seems upstream has acknowledged the bug and will merge the patch. See: https://gitlab.com/inkscape/inkscape/-/issues/1798

In the mean time I think we should have a media-gfx/inkscape-1.0-r2 with this patch applied, as it breaks upgrades for users.
Comment 11 Larry the Git Cow gentoo-dev 2020-08-26 06:49:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c36c147924e3eb82b7c120c85fd996f621fec6ea

commit c36c147924e3eb82b7c120c85fd996f621fec6ea
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2020-08-26 06:49:11 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2020-08-26 06:49:52 +0000

    media-gfx/inkscape: fix missing atomic include
    
    Closes: https://bugs.gentoo.org/737596
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 media-gfx/inkscape/files/missing_atomic_include.patch | 10 ++++++++++
 media-gfx/inkscape/inkscape-1.0-r1.ebuild             |  4 ++++
 2 files changed, 14 insertions(+)