Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 737152 - sys-devel/m4-1.4.18-r1 creates wrong gm4 symlink on prefix
Summary: sys-devel/m4-1.4.18-r1 creates wrong gm4 symlink on prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-08-14 23:14 UTC by Alexey
Modified: 2020-09-13 22:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_737152.txt,15.72 KB, text/plain)
2020-08-14 23:14 UTC, Alexey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2020-08-14 23:14:22 UTC
Created attachment 654668 [details]
emerge --info

user@mytest ~/gentoo $ ls -l /home/user/gentoo/usr/bin/gm4
lrwxrwxrwx 1 user user 11 Jul 20 01:17 /home/user/gentoo/usr/bin/gm4 -> /usr/bin/m4

user@mytest ~/gentoo $ ls -l /home/user/gentoo/usr/bin/m4
-rwxr-xr-x 1 user user 162816 Jul 20 01:17 /home/user/gentoo/usr/bin/m4

user@mytest ~/gentoo $ ls -l /usr/bin/m4
ls: cannot access '/usr/bin/m4': No such file or directory
Comment 1 Larry the Git Cow gentoo-dev 2020-09-13 09:57:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d937c1f2d37ccf9dc15440ef5ee75a3d827ba25d

commit d937c1f2d37ccf9dc15440ef5ee75a3d827ba25d
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2020-09-13 09:57:09 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2020-09-13 09:57:30 +0000

    sys-devel/m4: fix gm4 symlink target, thanks Alexey
    
    Closes: https://bugs.gentoo.org/737152
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 sys-devel/m4/m4-1.4.17.ebuild    | 2 +-
 sys-devel/m4/m4-1.4.18-r1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 2 Alexey 2020-09-13 10:21:50 UTC
I thought the fixed package needs reinstallation for the fix to apply, which is why I revbumped it in PR.
Is that not the case?
Comment 3 Fabian Groffen gentoo-dev 2020-09-13 12:18:09 UTC
Well, this only affects prefix users who use standalone prefix (=linux).  I figured for those this dangling symlink will not cause to many issues (if any), therefore didn't want the whole gentoo user-base to re-emerge m4 to fix this issue for standalone linux prefix users only.
Comment 4 Arfrever Frehtes Taifersar Arahesis 2020-09-13 21:31:34 UTC
(In reply to comment #1)

Relative symlink would be better:
use prefix && dosym m4 /usr/bin/gm4
Comment 5 Larry the Git Cow gentoo-dev 2020-09-13 22:30:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40160de0851297d83efe15434c2e46c9a4f56093

commit 40160de0851297d83efe15434c2e46c9a4f56093
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-09-13 22:29:03 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-09-13 22:29:03 +0000

    sys-devel/m4: use relative path for symlink target
    
    Bug: https://bugs.gentoo.org/737152
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-devel/m4/m4-1.4.17.ebuild    | 2 +-
 sys-devel/m4/m4-1.4.18-r1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)