Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736858 - kde-apps/yakuake-20.04.3: Shortcut for fullscreen mode broken
Summary: kde-apps/yakuake-20.04.3: Shortcut for fullscreen mode broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: CC-ARCHES, REGRESSION
Depends on:
Blocks:
 
Reported: 2020-08-12 08:36 UTC by Agostino Sarubbo
Modified: 2020-08-30 08:02 UTC (History)
0 users

See Also:
Package list:
kde-apps/yakuake-20.04.3-r1
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-08-12 08:36:52 UTC
I have a terminal 172x20. When I type the shortcut for the fullscreen mode it becomes 172x21

To put it in fullscreen mode I have to:
- type again the shortcut for the fullscreen mode (that puts it in 172x20 again)
- type again the shortcut for the fullscreen mode that finally goes into fullscreen

Downgrading to 20.04.2 fixes the problem for me.
I can attach a gif if is needed.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-08-18 14:37:44 UTC
There's a commit in 20.04.3 to actually fix some maximise behaviour: https://bugs.kde.org/show_bug.cgi?id=414049

You could test-revert that and follow-up with upstream on the matter.
Comment 2 Agostino Sarubbo gentoo-dev 2020-08-18 16:39:27 UTC
Hi, I saw the related commits but version 20.04.3 is exactly the version that does not work for me.

I don't know which commit breaks but since 20.04.3 does not work for me and 20.04.2 works for me I'd say that break is one of these commits:

https://github.com/KDE/yakuake/compare/v20.04.2...v20.04.3
Comment 3 Andreas Sturmlechner gentoo-dev 2020-08-18 16:41:35 UTC
The bug tells you exactly which one is the interesting commit. I'm sure you know how to revert and apply a patch for testing.
Comment 4 Agostino Sarubbo gentoo-dev 2020-08-18 16:55:40 UTC
sure, I will test asap and report here
Comment 5 Agostino Sarubbo gentoo-dev 2020-08-18 17:14:30 UTC
by reverting the commit 40326335554565cbc5a1ed9938828d60fa7cd214 it works for me.

How we should proceed at this point?
Comment 6 Andreas Sturmlechner gentoo-dev 2020-08-18 17:24:09 UTC
(In reply to Andreas Sturmlechner from comment #1)
> ... and follow-up with upstream on the matter.
Comment 7 Andreas Sturmlechner gentoo-dev 2020-08-18 17:25:38 UTC
Can you reproduce the same behaviour with konsole-20.08.0 and yakuake-20.08.0?
Comment 8 Andreas Sturmlechner gentoo-dev 2020-08-22 19:04:41 UTC
(In reply to Andreas Sturmlechner from comment #7)
> Can you reproduce the same behaviour with konsole-20.08.0 and
> yakuake-20.08.0?
At least I can't.
Comment 9 Agostino Sarubbo gentoo-dev 2020-08-22 19:48:35 UTC
(In reply to Andreas Sturmlechner from comment #8)
> (In reply to Andreas Sturmlechner from comment #7)
> > Can you reproduce the same behaviour with konsole-20.08.0 and
> > yakuake-20.08.0?
> At least I can't.

I'll test that version and report back
Comment 10 Andreas Sturmlechner gentoo-dev 2020-08-22 19:51:12 UTC
This commit looks promising: https://invent.kde.org/utilities/yakuake/-/commit/21b2d50d4c23cd375acda57ed03af288ae0651af
Comment 11 Larry the Git Cow gentoo-dev 2020-08-22 20:32:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19205cda205f5f66ebd4cf18ee4627a7b268d2bb

commit 19205cda205f5f66ebd4cf18ee4627a7b268d2bb
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-08-22 20:31:30 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-08-22 20:31:45 +0000

    kde-apps/yakuake: Fix fullscreen mode regression
    
    KDE-Bug: https://bugs.kde.org/show_bug.cgi?id=424286
    Reported-by: Agostino Sarubbo <ago@gentoo.org>
    Bug: https://bugs.gentoo.org/736858
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...ke-20.04.3-fix-fullscreen-mode-regression.patch | 37 +++++++++++++
 kde-apps/yakuake/yakuake-20.04.3-r1.ebuild         | 60 ++++++++++++++++++++++
 2 files changed, 97 insertions(+)
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-23 08:35:48 UTC
arm64 done
Comment 13 Thomas Deutschmann (RETIRED) gentoo-dev 2020-08-30 01:33:54 UTC
x86 stable