Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736545 - net-wireless/iwd: replace crda USE flag with check for kernel version <4.15
Summary: net-wireless/iwd: replace crda USE flag with check for kernel version <4.15
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-09 15:55 UTC by charles17
Modified: 2020-09-03 17:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description charles17 2020-08-09 15:55:16 UTC
Kernels not older that 4.15 don't need net-wireless/crda, see
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/crda.git/tree/README#n8

The (+)crda USE flag should be replaced with an appropriate check for old kernel version and the WARNING_CFG80211_CRDA_SUPPORT be limited to only those older kernel versions.
Comment 1 Ben Kohler gentoo-dev 2020-08-11 13:14:54 UTC
The problem is that several other pieces have to be in place for this non-crda setup to work, the USE flag helps enforce those.  But we can also add a kernel version check if you want.

Even on >=4.15, you can use crda and it's actually the easiest (less reliant on specific kernel settings) way.
Comment 2 Ben Kohler gentoo-dev 2020-09-03 13:28:27 UTC
I'm adding a new check for <4.15, I think that is the best we can do for now.  I think we do still need to keep the USE flag so that users can explicitly select the regulatory domain method they want, and the ebuild can (do its best to) check for all required support for that method.
Comment 3 Larry the Git Cow gentoo-dev 2020-09-03 17:37:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0338bf162978025ca9260648dbcdbd457c9a2bf4

commit 0338bf162978025ca9260648dbcdbd457c9a2bf4
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-09-03 13:29:19 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-09-03 17:37:33 +0000

    net-wireless/iwd: add kernel version check related to crda support
    
    Closes: https://bugs.gentoo.org/736545
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-wireless/iwd/iwd-1.8-r1.ebuild | 4 ++++
 1 file changed, 4 insertions(+)