Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736469 - dev-scheme/guile-1.8.8-r3: fails to compile with sys-apps/texinfo-6.7
Summary: dev-scheme/guile-1.8.8-r3: fails to compile with sys-apps/texinfo-6.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Scheme Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-08-09 02:40 UTC by Dennis Nezic
Modified: 2020-10-07 15:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix the 2 invalid utf8 bytes (malformedutf8.patch,1.21 KB, patch)
2020-08-09 02:40 UTC, Dennis Nezic
Details | Diff
emerge --info (emerge.info,14.73 KB, text/plain)
2020-09-18 15:09 UTC, Dave Kemper
Details
build log (build.log,219.00 KB, text/plain)
2020-09-18 15:12 UTC, Dave Kemper
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nezic 2020-08-09 02:40:36 UTC
Created attachment 653853 [details, diff]
patch to fix the 2 invalid utf8 bytes

There is a tiny "malformed utf8" byte in guile-1.8.8's documentation files that causes the package to fail during compilation. Apparently texinfo 6.5 was able to process it, but 6.7 can't.

Upstream says that they're in a code freeze and that we should replace the byte with an ASCII space[1]. So I did, with the attached patch. Hopefully gentoo patch files can handle weird utf8 characters in them? If not we could hack the culprit files in an uglier way in src_prepare() maybe?

For example:

sed -i '908d' ./doc/ref/api-compound.texi
sed -i '908iAcquire a handle for the vector @var{vec} and return a pointer to the' ./doc/ref/api-compound.texi

sed -i '4195d' ./doc/ref/api-compound.texi
sed -i '4195i     Acquire a handle for the vector @var{vec} and return a pointer to the' ./doc/ref/api-compound.texi


[1] http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/guile/Makefile?rev=1.112&content-type=text/x-cvsweb-markup
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-11 07:21:20 UTC
Please include the failed build log and emerge --info.
Comment 2 Dennis Nezic 2020-08-11 12:19:34 UTC
It fails with the error message mentioned in that upstream link:

utf8 "\xA0" does not map to Unicode at ParserNonXS.pm line 1796, <FH> line 908.
Malformed UTF-8 character: \xa0 (unexpected continuation byte 0xa0, with no
preceding start byte) in pattern match (m//) at ParserNonXS.pm line 3364.
Malformed UTF-8 character (fatal) at ParserNonXS.pm line 3364.

It wasn't very informative, I had to hack around a bit to find exactly which files were causing it (api-compound.texi and guile.info-2 ... if you look at those two source files you'll find a single random weird UTF8 character in each of them.)
Comment 3 Dave Kemper 2020-09-18 15:09:43 UTC
Created attachment 661170 [details]
emerge --info

I'm not the original submitter, but I'm encountering the same problem, so posting info requested in comment #1.
Comment 4 Dave Kemper 2020-09-18 15:12:49 UTC
Created attachment 661173 [details]
build log
Comment 5 Dave Kemper 2020-09-30 07:05:38 UTC
Please advise what further information is needed to move this bug out of the  NEEDINFO state.  Thank you.
Comment 6 Larry the Git Cow gentoo-dev 2020-10-05 19:04:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f32eaf545ba48564c1ba109fc2792079257032b

commit 3f32eaf545ba48564c1ba109fc2792079257032b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-10-05 19:03:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-05 19:03:59 +0000

    dev-scheme/guile: fix 1.8.8 build with >=sys-apps/texinfo-6.7
    
    Drop unicode.
    
    Thanks-to: Dennis Nezic <dennisn@dennisn.mooo.com>
    Closes: https://bugs.gentoo.org/736469
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Sam James <sam@gentoo.org>

 .../guile/files/guile-1.8.8-texinfo-6.7.patch      | 22 ++++++++++++++++++++++
 dev-scheme/guile/guile-1.8.8-r3.ebuild             |  3 ++-
 2 files changed, 24 insertions(+), 1 deletion(-)
Comment 7 Dave Kemper 2020-10-07 11:34:24 UTC
I confirm this solves the problem.  Thank you!!
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-07 15:09:59 UTC
(In reply to Dave Kemper from comment #7)
> I confirm this solves the problem.  Thank you!!

Fabulous, thanks for letting me know it's working btw!