Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736442 - [kde overlay] kde-plasma/plasma-workspace-9999 USE=screencast request
Summary: [kde overlay] kde-plasma/plasma-workspace-9999 USE=screencast request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-08 19:07 UTC by Duncan
Modified: 2020-08-09 09:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2020-08-08 19:07:44 UTC
In a sentence: Upstream plasma-workspace isn't (yet) requiring pipewire so it should be a USE flag.

kde overlay commit d1bb894c3 requires pipewire, but it's explicitly /not/ an upstream plasma-workspace requirement.  Neither of the upstream commits mentioned in the (overlay) commit, plasma-workspace 157a82d78 and 949aaf7b0, "require" it, and the packager's announcement says it's "(for now optional)"[1].  Additionally, I've updated plasma-workspace at least twice since those (upstream) commits without installing pipewire, so I know for certain it's not required, either to build or to run.

Of course  the normal Gentoo way to deal with such options are USE flags so I propose adding a wirepipe USE flag, at least until such time as upstream actually does start requiring it.

Given upstream's justification is wayland desktop recording/streaming and remote-desktop sharing and many users/distros likely staying on X until plasma6, hopefully upstream holds off on making it required at least until then.

--
[1] https://mail.kde.org/pipermail/release-team/2020-July/011973.html
Comment 1 Andreas Sturmlechner gentoo-dev 2020-08-08 23:08:32 UTC
When you look at the actual upstream commit (mentioned in kde overlay git message) you see it is not optional (header use).

https://invent.kde.org/plasma/plasma-workspace/-/commit/157a82d7859f685a30988b5a4c32b9a4b8f06629
Comment 2 Arfrever Frehtes Taifersar Arahesis 2020-08-09 06:21:59 UTC
Since https://invent.kde.org/plasma/plasma-workspace/-/commit/18b0072f5981ff252112e4e8146779edd46b85e3 inclusions of those headers are inside '#ifdef WITH_PIPEWIRE' blocks.
Comment 3 Andreas Sturmlechner gentoo-dev 2020-08-09 09:29:32 UTC
Thanks, will see how it goes. Yet another sed...
Comment 4 Larry the Git Cow gentoo-dev 2020-08-09 09:32:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=870dfcb3597a9e6324d96c1e2ea15f62203dd2de

commit 870dfcb3597a9e6324d96c1e2ea15f62203dd2de
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-08-09 09:31:22 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-08-09 09:31:22 +0000

    kde-plasma/plasma-workspace: Add IUSE="screencast"
    
    Closes: https://bugs.gentoo.org/736442
    Package-Manager: Portage-3.0.2, Repoman-2.3.23
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/plasma-workspace/metadata.xml                 |  1 +
 kde-plasma/plasma-workspace/plasma-workspace-9999.ebuild | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)