Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736268 - games-strategy/widelands-0.21 version bump
Summary: games-strategy/widelands-0.21 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-07 14:01 UTC by matthias.grobarek
Modified: 2021-06-03 16:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed ebuild file for 0.21 (widelands-0.21.ebuild,1.50 KB, text/plain)
2020-08-07 14:02 UTC, matthias.grobarek
Details
ebuild diff 0.20-r1 → 0.21 (widelands-ebuild.diff,779 bytes, patch)
2020-08-07 15:43 UTC, matthias.grobarek
Details | Diff
widelands ebuild with support for lua-single eclass (widelands-0.21-r100.ebuild,1.58 KB, text/plain)
2021-01-19 05:26 UTC, Samuel Bauer
Details
ebuild for 0.21 (widelands-0.21-r101.ebuild,1.88 KB, text/plain)
2021-02-01 16:35 UTC, Florian E. Teply
Details
patch based on 0.20-r1 (widelands-0.20-to-0.21.patch,2.20 KB, patch)
2021-02-01 16:36 UTC, Florian E. Teply
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description matthias.grobarek 2020-08-07 14:01:40 UTC
In July, Widelands 0.21 was released: https://www.widelands.org/news/2020/Jul/18/widelands-build-21-released/

I tried to use the 0.20-r1 ebuild but encountered some minor problems, e.g. the patch files aren’t necessary anymore. I fixed this; please find attached my fixed ebuild file.

Reproducible: Always
Comment 1 matthias.grobarek 2020-08-07 14:02:28 UTC
Created attachment 653596 [details]
Fixed ebuild file for 0.21
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-08-07 15:32:40 UTC
Thank you for the ebuild. If you want to make our work a bit easier, please attach a unified diff to the bug instead of the full ebuild. That way we can easier see what you have changed.
Comment 3 matthias.grobarek 2020-08-07 15:43:01 UTC
Created attachment 653610 [details, diff]
ebuild diff 0.20-r1 → 0.21
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-08-07 16:21:51 UTC
Unfortunately the ebuild requires further tweaking beacuse right now there's stuff being installed into /usr/share/doc/share which doesn't belong there.
Comment 5 Samuel Bauer 2021-01-19 05:26:41 UTC
Created attachment 683617 [details]
widelands ebuild with support for lua-single eclass
Comment 6 Florian E. Teply 2021-02-01 16:35:41 UTC
Created attachment 685440 [details]
ebuild for 0.21

updated ebuild for 0.21
Comment 7 Florian E. Teply 2021-02-01 16:36:13 UTC
Created attachment 685443 [details, diff]
patch based on 0.20-r1
Comment 8 Florian E. Teply 2021-02-01 16:39:26 UTC
The attached ebuild (based on the one from Samuel Bauer) should also fix the issue with files inappropriately being installed into /usr/share/doc/share.

Update of icon cache added as well to get rid of portage QA note.

Might not be the cleanest solution, but the CMake files seem to be a bit, umm, hard to grasp, so I opted for the quick'n'dirty approach ;-)
Comment 9 Samuel Bauer 2021-02-01 17:43:41 UTC
(In reply to Florian E. Teply from comment #8)
> The attached ebuild (based on the one from Samuel Bauer) should also fix the
> issue with files inappropriately being installed into /usr/share/doc/share.
> 
> Update of icon cache added as well to get rid of portage QA note.
> 
> Might not be the cleanest solution, but the CMake files seem to be a bit,
> umm, hard to grasp, so I opted for the quick'n'dirty approach ;-)

Nice, I've also done a r100 patch locally, but still encountered the /usr/share/doc/share issue which I didn't really focus on
Comment 10 Larry the Git Cow gentoo-dev 2021-06-03 16:25:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b8fb6aa58c65e3faf26d14cc0e4564adfb20ab3d

commit b8fb6aa58c65e3faf26d14cc0e4564adfb20ab3d
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-03 14:15:08 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-03 16:17:51 +0000

    games-strategy/widelands: add 0.21
    
    - add python3_{9,10}
    - enable minor tests
    - let trivial website tools be built
    - removed upstreamed patches
    - use upstream provided .desktop
    - update LICENSE for the various assets
    
    Closes: https://bugs.gentoo.org/718116
    Closes: https://bugs.gentoo.org/736268
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-strategy/widelands/Manifest              |  1 +
 games-strategy/widelands/widelands-0.21.ebuild | 58 ++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 11 Ionen Wolkens gentoo-dev 2021-06-03 16:29:58 UTC
Late bump considering 1.0 is coming soon, but here it is anyway (also updated live ebuild in preparation).

Went a different way about it but thanks for the reference ebuilds, it helps to see changes.