dev-libs/cyberjack-3.99.5_p14-r1 unnecessarily throws the message: * Messages for package dev-libs/cyberjack-3.99.5_p14-r1: * CONFIG_USB_SERIAL_CYBERJACK: is not set when it should be. * Please check to make sure these options are set correctly. * Failure to do so may cause unexpected problems. >>> Auto-cleaning packages... This could misguide users to enable an unneeded kernel driver.
Furthermore, some of the products listed in files/libifd-cyberjack6.udev don't match with hwids. diff --git a/dev-libs/cyberjack/files/libifd-cyberjack6.udev b/dev-libs/cyberjack/files/libifd-cyberjack6.udev index 6d5c99a1247..7784f2477f3 100644 --- a/dev-libs/cyberjack/files/libifd-cyberjack6.udev +++ b/dev-libs/cyberjack/files/libifd-cyberjack6.udev @@ -7,21 +7,11 @@ ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0100", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0300", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0400", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0401", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0412", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0485", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0500", ENV{PCSCD}="1" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0501", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0502", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0503", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0504", MODE="660", GROUP="pcscd" ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0505", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0506", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0507", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0525", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0580", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="2000", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0551", MODE="660", GROUP="pcscd" -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="2002", MODE="660", GROUP="pcscd" # All done LABEL="cyberjack_rules_end"
(In reply to charles17 from comment #1) > Furthermore, some of the products listed in files/libifd-cyberjack6.udev > don't match with hwids. ... compared to https://github.com/gentoo/hwids/blob/master/usb.ids#L13349
Hi! (In reply to charles17 from comment #0) > * CONFIG_USB_SERIAL_CYBERJACK: is not set when it should be. > * Please check to make sure these options are set correctly. > * Failure to do so may cause unexpected problems. > >>> Auto-cleaning packages... > > This could misguide users to enable an unneeded kernel driver. Well, tbh, that check is ancient and was already in it, before I took over. But instead of dropping it, since it's needed for some devices, I will add a custom warning message, so it should be clear for the users, when this option will be needed.(In reply to charles17 from comment #1) > Furthermore, some of the products listed in files/libifd-cyberjack6.udev > don't match with hwids. Well, that the original file, which is provided directly by upstream, at least lastly in SP13 and SP14 is missing udev rules at all. > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0412", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0485", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0503", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0506", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0507", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0525", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0580", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="2000", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="0551", MODE="660", GROUP="pcscd" > -ATTR{idVendor}=="0c4b", ATTR{idProduct}=="2002", MODE="660", GROUP="pcscd" If I undertand your diff, this are all entries, which are not found in the usb.ids. I am not sure about that, if usb.ids is complete. The windows driver knows all those ids. For example 0412 seems to be, at least for the windows driver, called "REINER SCT cyberJack secoder TLS".
(In reply to Conrad Kostecki from comment #3) > Hi! > > (In reply to charles17 from comment #0) > > * CONFIG_USB_SERIAL_CYBERJACK: is not set when it should be. > > * Please check to make sure these options are set correctly. > > * Failure to do so may cause unexpected problems. > > >>> Auto-cleaning packages... > > > > This could misguide users to enable an unneeded kernel driver. > > Well, tbh, that check is ancient and was already in it, before I took over. > But instead of dropping it, since it's needed for some devices, Am I misreading the »It is implemented 100% in userspace« statement in the package's documentation? Here in /usr/share/doc/cyberjack-3.99.5_p14-r1/README.txt.bz2 it says: 1. Overview This driver for the REINER SCT cyberJack pinpad/e-com USB family of chipcard readers implements the CT-API 1.1 interface, as well as the PC/SC interface of pcsc-lite. It is implemented 100% in userspace. This means no trouble with different kernel versions, compiling/patching the kernel etc. All accesses are done via the usb devfs in /proc/bus/usb (or /dev/bus/usb for udev-based systems).
(In reply to charles17 from comment #4) > Am I misreading the »It is implemented 100% in userspace« statement in the > package's documentation? > Here in /usr/share/doc/cyberjack-3.99.5_p14-r1/README.txt.bz2 it says: No, you are right, I have overseen that. FWICS, the kernel modules provides /dev/ttyUSB for that device, but it seems not to be used by the cyberjack driver. I guess it's time to drop that old check. Digging further this seems to be used a long time ago.
(In reply to Conrad Kostecki from comment #5) > No, you are right, I have overseen that. Thanks for checking. May I propose to get hotplugging supported also for all the other USB devices supported by this driver? I only have "0500" but I guess it be beneficial for all of them.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4812c9ef3ec1cbfa3f2a9bd2c1c77285b1e5aeda commit 4812c9ef3ec1cbfa3f2a9bd2c1c77285b1e5aeda Author: Conrad Kostecki <conikost@gentoo.org> AuthorDate: 2020-08-19 16:24:33 +0000 Commit: Conrad Kostecki <conikost@gentoo.org> CommitDate: 2020-08-19 16:27:04 +0000 dev-libs/cyberjack: update udev rules Also dropped ancient check for kernel module, as it's not needed for cyberjack, since everything is now userspace nowerdays. Closes: https://bugs.gentoo.org/736034 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Conrad Kostecki <conikost@gentoo.org> dev-libs/cyberjack/cyberjack-3.99.5_p14-r2.ebuild | 90 ++++++++++++++++++++++ dev-libs/cyberjack/files/libifd-cyberjack6.udev-r1 | 27 +++++++ 2 files changed, 117 insertions(+)
