now working on bump to audacity-2.4.2 that deps on lame but ignores the installed one as it does not provide .pc file.
Official lame sources do not provide a pkgconfig file. I've seen a request from back in 2006 to add one[1] but it never happened. Debian also had a bug open with a pkgconfig file request[2] that even got merged but looking at their current lame packages, I don't see a pkgconfig file being shipped anymore. What filename does audacity expect the lame pkgconfig file to have? Just for the record, implementing a patch was quite easy and I do have one in my git stash right now but I doubt this is the right approach as long as the pkgconfig is not part of the official upstream sources. [1] https://sourceforge.net/p/lame/mailman/lame-dev/thread/20060227122155.GA13175%40fargo/#msg9923548 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829327
here is the code that is used to find the system deps: https://github.com/audacity/audacity/blob/Audacity-2.4.2/cmake-proxies/CMakeLists.txt#L83 idk how to otherwise avoid the silent issue that some system packages are ignored and the bundled ones are used instead. btw, libmad does not provide mad.pc either, but we do.
Thanks for the link. Unfortunately only by looking at the code I cannot see what .pc file audacity expects to find lame. The patch I took from Debian names the file "mp3lame.pc". That's what I used for the patch I wrote up as well.
i just manually created this file: /usr/lib64/pkgconfig/lame.pc and this is the output of audacity-2.4.2: -- ========== Configuring lame ========== -- Checking for module 'lame >= 3.100' -- Found lame , version 3.100 -- Using 'lame' system library so it expects lame.pc.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dcd31f9e1b275bd6f8c126ee11f58da07a81ad5 commit 2dcd31f9e1b275bd6f8c126ee11f58da07a81ad5 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2020-08-02 17:23:03 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2020-08-02 17:23:41 +0000 media-sound/lame: Revbump to add a pkgconfig file Bug: https://bugs.gentoo.org/735168 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> media-sound/lame/files/lame-3.100-pkgconfig.patch | 45 +++++++++++++ media-sound/lame/lame-3.100-r3.ebuild | 82 +++++++++++++++++++++++ 2 files changed, 127 insertions(+)
Please report back if that satisfies audacity.
works perfectly, thanks! :-) - ========== Configuring lame ========== -- Checking for module 'lame >= 3.100' -- Found lame , version 3.100 -- Using 'lame' system library
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bccb35a57f821522e391c2342b24d0efbed06ef commit 1bccb35a57f821522e391c2342b24d0efbed06ef Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-02 18:22:59 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-02 18:23:14 +0000 media-sound/audacity: restricted 2.4.2 dep to lame with .pc file otherwise audacity silently uses the bundled one Bug: https://bugs.gentoo.org/735168 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> .../audacity/{audacity-2.4.2.ebuild => audacity-2.4.2-r1.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
