Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 735140 - dev-python/pypy3: 7.3.1-gentoo-path.patch typo breaks INSTALL_SCHEMES fix
Summary: dev-python/pypy3: 7.3.1-gentoo-path.patch typo breaks INSTALL_SCHEMES fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-08-01 23:44 UTC by Tom Gillespie
Modified: 2020-08-02 09:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Gillespie 2020-08-01 23:44:07 UTC
This is a reappearance of https://bugs.gentoo.org/465546, caused by copying a patch file without changing the pypy version. I have a PR incoming that fixes this in a way that will prevent this from happening again in the future and should prevent the need to bump the pypy python version inside the patch.

Reproducible: Always

Steps to Reproduce:
Try to install a python package with pypy3 support that has a data section that wants to put something in /usr/share/.
Comment 1 Larry the Git Cow gentoo-dev 2020-08-02 09:35:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae017fcc14207aadf50344392d7d869e7ef1eb53

commit ae017fcc14207aadf50344392d7d869e7ef1eb53
Author:     Tom Gillespie <tgbugs@gmail.com>
AuthorDate: 2020-08-02 08:38:19 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-08-02 09:35:01 +0000

    dev-python/pypy3: fix gentoo-path.patch and rev bump
    
    Test that install_path starts with '/usr/lib/pypy' instead of doing an
    exact equality == test against the specific pypy version. This will
    allow the patch to be reused between pypy and pypy3 without the risk of
    having the gentoo specific fix fail to be detected due to a mismatched
    pypy version number. This also prevents the need to maintain an exact
    match the pypy version in the future since it will continue to change
    and I assume there is also the possibility that both pypy3.6 and pypy3.7
    might be installed on the same system at the same time.
    
    Also rev bump so that users will recieve the fix.
    
    This also removes a blocker for https://bugs.gentoo.org/729958 and
    https://github.com/gentoo/gentoo/pull/16466.
    
    Closes: https://bugs.gentoo.org/735140
    Related-to: https://bugs.gentoo.org/729958
    Signed-off-by: Tom Gillespie <tgbugs@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16943
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/pypy3/files/7.3.1-gentoo-path.patch                    | 2 +-
 dev-python/pypy3/{pypy3-7.3.1-r1.ebuild => pypy3-7.3.1-r2.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)