Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 735132 - app-emulation/lxc-4.0.2-r2 should check that CONFIG_MEMCG is set
Summary: app-emulation/lxc-4.0.2-r2 should check that CONFIG_MEMCG is set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-08-01 22:38 UTC by Stephen Bosch
Modified: 2020-08-05 06:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Set CONFIG_MEMCG (lxc-4.0.2-r3.ebuild.patch,734 bytes, patch)
2020-08-01 22:39 UTC, Stephen Bosch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Bosch 2020-08-01 22:38:09 UTC
The ebuild does not check if CONFIG_MEMCG is set.

If kernel CONFIG_MEMCG is not set, then the memory controller is not configured and container memory limits will not work in lxc or lxd.

Reproducible: Always
Comment 1 Stephen Bosch 2020-08-01 22:39:34 UTC
Created attachment 652212 [details, diff]
Set CONFIG_MEMCG
Comment 2 Joonas Niilola gentoo-dev 2020-08-04 12:22:58 UTC
https://github.com/lxc/lxc/blob/6dc1208ded87c9b3db70aa43cca61857e0d19428/src/lxc/cmd/lxc-checkconfig.in#L193 indeed. If you'd like to get credited in git (shows up in Github) please make a git-appliable patch with proper sign-off included.
Comment 3 Stephen Bosch 2020-08-04 13:01:38 UTC
(In reply to Joonas Niilola from comment #2)
> https://github.com/lxc/lxc/blob/6dc1208ded87c9b3db70aa43cca61857e0d19428/src/
> lxc/cmd/lxc-checkconfig.in#L193 indeed. If you'd like to get credited in git
> (shows up in Github) please make a git-appliable patch with proper sign-off
> included.

Sure, I'd like that. What's the best way to do that?
Comment 4 Stephen Bosch 2020-08-04 13:03:06 UTC
(In reply to Stephen Bosch from comment #3)
> (In reply to Joonas Niilola from comment #2)
> > https://github.com/lxc/lxc/blob/6dc1208ded87c9b3db70aa43cca61857e0d19428/src/
> > lxc/cmd/lxc-checkconfig.in#L193 indeed. If you'd like to get credited in git
> > (shows up in Github) please make a git-appliable patch with proper sign-off
> > included.
> 
> Sure, I'd like that. What's the best way to do that?

Never mind. Found this: https://wiki.gentoo.org/wiki/Gentoo_GitHub
Comment 5 Larry the Git Cow gentoo-dev 2020-08-05 06:44:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22571aa100b404068b27c28b2365855c1426fce0

commit 22571aa100b404068b27c28b2365855c1426fce0
Author:     Stephen Bosch <posting@vodacomm.ca>
AuthorDate: 2020-08-04 15:46:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-08-05 06:43:57 +0000

    app-emulation/lxc: Add MEMCG to config checks
    
    Closes: https://bugs.gentoo.org/735132
    Signed-off-by: Stephen Bosch <posting@vodacomm.ca>
    Closes: https://github.com/gentoo/gentoo/pull/17000
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-emulation/lxc/lxc-4.0.3.ebuild | 2 ++
 1 file changed, 2 insertions(+)