Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 735130 - improper contextfvars backport usage
Summary: improper contextfvars backport usage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-01 22:30 UTC by Georgy Yakovlev
Modified: 2020-08-02 21:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2020-08-01 22:30:33 UTC
Hi.

dev-python/contextvars
dev-python/aiocontextvars


are backports of python3.7+ functionality to python3.6


dev-python/yappi
should use 
> $(python_gen_cond_dep 'dev-python/contextvars[${PYTHON_USEDEP}]' 'python3_6')

instead of 
> dev-python/contextvars[${PYTHON_USEDEP}]



dev-python/logbook
has a hard blocker
> !!dev-python/contextvars
suggested in https://github.com/gentoo/gentoo/pull/15497

I think if the package will use cond_dep only for 3.6
and contextvars packages will have python3.7+ support removed, blocker should be removed as well.

of if it fails on python3_6 with contextvars backport - remove 3.6 support

action items for this bug:

1) fix yappi
2) remove py3.7+ support from {aio}contextvars
3) probably remove blocker from logbook
Comment 1 Georgy Yakovlev archtester gentoo-dev 2020-08-01 22:33:21 UTC
alternative would be - removing python3.6 support from all consumers and cleaning out the mentioned backport packages.
Comment 2 Larry the Git Cow gentoo-dev 2020-08-02 21:08:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22e503b220d0cf212a342698cdc7ab9e9cd7c441

commit 22e503b220d0cf212a342698cdc7ab9e9cd7c441
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-08-02 21:05:39 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-08-02 21:08:18 +0000

    dev-python/aiocontextvars: remove py3.7+ support
    
    Bug: https://bugs.gentoo.org/735130
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-python/aiocontextvars/aiocontextvars-0.2.2.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1217df3c839c8f3f7df2ba43a06b44cad6dfcbe0

commit 1217df3c839c8f3f7df2ba43a06b44cad6dfcbe0
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-08-02 21:04:29 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-08-02 21:08:18 +0000

    dev-python/contextvars: remove py3.7+ support
    
    Bug: https://bugs.gentoo.org/735130
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-python/contextvars/contextvars-2.4.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=971b0552690fa0b0c6ac7059cb2f76c791f1ca17

commit 971b0552690fa0b0c6ac7059cb2f76c791f1ca17
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-08-02 21:02:16 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-08-02 21:08:17 +0000

    dev-python/yappi: rebvbump, fix backport dep
    
    Bug: https://bugs.gentoo.org/735130
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-python/yappi/{yappi-1.2.5.ebuild => yappi-1.2.5-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Georgy Yakovlev archtester gentoo-dev 2020-08-02 21:17:39 UTC
Ok blocker in logbook will remain.

Code has conditional contextvars import, but looks like it need real one found in 3.7+, not the backported version.


Not a big deal, because defalult python is 3.7 nowadays, hence contextvars backport is unlikely to be installed, unless users force it. Closing.