Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 735014 - >dev-python/wtforms-2.3.1: Optional RDEPEND on dev-python/python-email-validator - (dev-db/pgadmin4: Exception: Install 'email_validator' for email validation support.)
Summary: >dev-python/wtforms-2.3.1: Optional RDEPEND on dev-python/python-email-valida...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
: 736976 (view as bug list)
Depends on: 755260
Blocks:
  Show dependency tree
 
Reported: 2020-08-01 07:32 UTC by martin.schmidt13
Modified: 2020-12-25 03:17 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description martin.schmidt13 2020-08-01 07:32:06 UTC
1. pgAdmin4 -> doesn't start successfully.

2. Investigating the issue via execution of

python /usr/share/pgadmin4/web/pgAdmin4.py
gives me:

Traceback (most recent call last):
  File "/usr/share/pgadmin4/web/pgAdmin4.py", line 40, in <module>
    import config
  File "/usr/share/pgadmin4/web/config.py", line 30, in <module>
    from pgadmin.utils import env, IS_PY2, IS_WIN, fs_short_path
  File "/usr/share/pgadmin4/web/pgadmin/__init__.py", line 25, in <module>
    from flask_security import Security, SQLAlchemyUserDatastore, current_user
  File "/usr/lib/python3.7/site-packages/flask_security/__init__.py", line 13, in <module>
    from .core import Security, RoleMixin, UserMixin, AnonymousUser, current_user
  File "/usr/lib/python3.7/site-packages/flask_security/core.py", line 28, in <module>
    from .forms import ChangePasswordForm, ConfirmRegisterForm, \
  File "/usr/lib/python3.7/site-packages/flask_security/forms.py", line 69, in <module>
    email_validator = Email(message='INVALID_EMAIL_ADDRESS')
  File "/usr/lib/python3.7/site-packages/wtforms/validators.py", line 332, in __init__
    raise Exception("Install 'email_validator' for email validation support.")
Exception: Install 'email_validator' for email validation support.

3. Installation of dev-python/python-email-validator fixes this problem for me.

So i think, the ebuild is missing a python-email-validator RDEPEND or is there any other reason?
Comment 1 Aaron W. Swenson gentoo-dev 2020-09-12 11:59:04 UTC
*** Bug 736976 has been marked as a duplicate of this bug. ***
Comment 2 Aaron W. Swenson gentoo-dev 2020-09-12 12:05:14 UTC
This doesn't appear to be an issue with dev-db/pgadmin4. I don't have python-email-validator installed, and PgAdmin 4 starts without an issue.


It's also been reported on Bug 736976 that the following packages are needed:
 - dev-python/extras
 - dev-python/fixtures
 - dev-python/linecache2
 - dev-python/pycodestyle
 - dev-python/python-mimeparse
 - dev-python/testscenarios
 - dev-python/testtools
 - dev-python/traceback2
 - dev-python/selenium
 - dev-python/coverage
 - dev-python/python-email-validator

More than half of those packages are not installed on my system, and 4.25 works without an issue.

Instead, it looks like the dev-python/python-email-validator needs to be RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others.
Comment 3 martin.schmidt13 2020-09-12 16:28:47 UTC
The error i reported is with "stable" pgadmin4-4.17-r1 i run.
Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-)
Comment 4 Aaron W. Swenson gentoo-dev 2020-09-12 20:29:22 UTC
(In reply to martin.schmidt13 from comment #3)
> The error i reported is with "stable" pgadmin4-4.17-r1 i run.
> Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-)

Poor wording on my part. I meant that 4.17 has always worked, and 4.25 works as well.

Which version of dev-python/wtforms do you have installed?
Comment 5 martin.schmidt13 2020-09-13 04:47:35 UTC
(In reply to Aaron W. Swenson from comment #4)
> (In reply to martin.schmidt13 from comment #3)
> > The error i reported is with "stable" pgadmin4-4.17-r1 i run.
> > Perhaps i should now try pgadmin4-4.25 - born 4 hours ago ... :-)
> 
> Poor wording on my part. I meant that 4.17 has always worked, and 4.25 works
> as well.
> 
> Which version of dev-python/wtforms do you have installed?

equery l dev-python/wtforms
 * Searching for wtforms in dev-python ...
[IP-] [  ] dev-python/wtforms-2.3.1:0
Comment 6 martin.schmidt13 2020-09-13 04:55:57 UTC
(In reply to Aaron W. Swenson from comment #2)
> This doesn't appear to be an issue with dev-db/pgadmin4. I don't have
> python-email-validator installed, and PgAdmin 4 starts without an issue.
> 
> 
> It's also been reported on Bug 736976 that the following packages are needed:
>  - dev-python/extras
>  - dev-python/fixtures
>  - dev-python/linecache2
>  - dev-python/pycodestyle
>  - dev-python/python-mimeparse
>  - dev-python/testscenarios
>  - dev-python/testtools
>  - dev-python/traceback2
>  - dev-python/selenium
>  - dev-python/coverage
>  - dev-python/python-email-validator
> 
> More than half of those packages are not installed on my system, and 4.25
> works without an issue.
> 
> Instead, it looks like the dev-python/python-email-validator needs to be
> RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others.

Wouldn't that mean python-email-validator needs to be present anyway ?
Comment 7 Aaron W. Swenson gentoo-dev 2020-09-15 02:30:20 UTC
(In reply to martin.schmidt13 from comment #6)
> (In reply to Aaron W. Swenson from comment #2)
> > This doesn't appear to be an issue with dev-db/pgadmin4. I don't have
> > python-email-validator installed, and PgAdmin 4 starts without an issue.
> > 
> > ...
> > 
> > Instead, it looks like the dev-python/python-email-validator needs to be
> > RDEPENDed in dev-python/wtforms packaged. I'm not sure about the others.
> 
> Wouldn't that mean python-email-validator needs to be present anyway ?

Yes, but we need to determine the package that actually needs it. PgAdmin doesn't need it, per se. So, it shouldn't declare a dependency on it.

It looks like starting with dev-python/wtforms-2.3.1, the email validation was shifted to an optional dependency, dev-python/python-email-validator. With <dev-python/wtforms-2.3.1, they managed a regex themselves. So, we need dev-python/python-email-validator to allow us to flip the email validation support on.

@python: What USE flag would we like to use?
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-15 06:11:37 UTC
Don't bother users with flipping meaningless flags, add the dep to pgadmin4.
Comment 9 Larry the Git Cow gentoo-dev 2020-09-24 09:50:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=124f7ccffce5387371bb24e04a276783e09b60d3

commit 124f7ccffce5387371bb24e04a276783e09b60d3
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2020-09-24 09:46:04 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2020-09-24 09:49:27 +0000

    dev-db/pgadmin4: Bump to 4.26
    
    Added indirect dependency on dev-python/python-email-validator.
    
    Bug: https://bugs.gentoo.org/735014
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 dev-db/pgadmin4/Manifest             |   1 +
 dev-db/pgadmin4/pgadmin4-4.26.ebuild | 128 +++++++++++++++++++++++++++++++++++
 2 files changed, 129 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2020-12-25 03:17:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f997bdc5009d9b7b78b57ddf1494867268eaca13

commit f997bdc5009d9b7b78b57ddf1494867268eaca13
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2020-12-25 03:16:08 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2020-12-25 03:16:08 +0000

    dev-db/pgadmin4: Cleanup
    
    Closes: https://bugs.gentoo.org/735014
    Closes: https://bugs.gentoo.org/744151
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 dev-db/pgadmin4/Manifest                           |   3 -
 .../pgadmin4/files/pgadmin4-4.17-python-3.8.patch  |  12 --
 dev-db/pgadmin4/pgadmin4-4.17-r1.ebuild            | 120 -------------------
 dev-db/pgadmin4/pgadmin4-4.25.ebuild               | 124 --------------------
 dev-db/pgadmin4/pgadmin4-4.28.ebuild               | 130 ---------------------
 5 files changed, 389 deletions(-)