Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734998 - app-misc/pax-utils: use BDEPEND with EAPI 7
Summary: app-misc/pax-utils: use BDEPEND with EAPI 7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-01 01:36 UTC by David Michael
Modified: 2020-08-01 13:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-08-01 01:36:12 UTC
The ebuild uses EAPI 7 but does not define BDEPEND.  It has pkgconfig in DEPEND, which causes it to be cross-compiled when it needs to be executed natively.  That needs to be moved to BDEPEND.

It also has xz-utils in DEPEND when it is not required as a cross-compiled build dependency, so that can also go in BDEPEND, but it could probably be dropped like other packages have been doing since it's in the base package list.

Reproducible: Always

Steps to Reproduce:
1. emerge -v app-misc/pax-utils  # with a sysroot profile

Actual Results:  
It installs pkgconfig in the sysroot.

Expected Results:  
It should install pkgconfig natively.

--- app-misc/pax-utils/pax-utils-1.2.6.ebuild
+++ app-misc/pax-utils/pax-utils-1.2.6.ebuild
@@ -25,7 +25,8 @@
 		')
 	)
 	seccomp? ( sys-libs/libseccomp )"
-DEPEND="${RDEPEND}
+DEPEND="${RDEPEND}"
+BDEPEND="
 	caps? ( virtual/pkgconfig )
 	seccomp? ( virtual/pkgconfig )
 	app-arch/xz-utils"
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-08-01 13:47:03 UTC
(In reply to David Michael from comment #0)
> It also has xz-utils in DEPEND when it is not required as a cross-compiled
> build dependency, so that can also go in BDEPEND, but it could probably be
> dropped like other packages have been doing since it's in the base package
> list.

The DEPEND presence reason is not presence in @system (in rare cases of circular depends might be valid too, but it's up to individual packages to specify the depends). EAPI=7 guarantees support .xz as-is without extra DEPENDs. Explicit depend is a leftover or unpacker.eclass usage for older EAPIs. I'll drop it.

> Steps to Reproduce:
> 1. emerge -v app-misc/pax-utils  # with a sysroot profile

I don't believe gentoo provides "sysroot profile"s by default, but it's too vague a description of an actual setup. '${CTARGET}-emerge --info' should render enough useful information. If it does not please file according bug against portage.

> --- app-misc/pax-utils/pax-utils-1.2.6.ebuild
> +++ app-misc/pax-utils/pax-utils-1.2.6.ebuild
> @@ -25,7 +25,8 @@
>  		')
>  	)
>  	seccomp? ( sys-libs/libseccomp )"
> -DEPEND="${RDEPEND}
> +DEPEND="${RDEPEND}"
> +BDEPEND="
>  	caps? ( virtual/pkgconfig )
>  	seccomp? ( virtual/pkgconfig )
>  	app-arch/xz-utils"

I suggest posting patches in 'git am' format next time. That should ease applying them as is.
Comment 2 Larry the Git Cow gentoo-dev 2020-08-01 13:50:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e388c6d781bfe82e3fb9f7c6d5aefa9ae13d933

commit 5e388c6d781bfe82e3fb9f7c6d5aefa9ae13d933
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-08-01 13:50:03 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-08-01 13:50:13 +0000

    app-misc/pax-utils: use BDEPEND for pkg-config
    
    While at it drop xz-utils depend as EAPI=7 guarantees .xz
    archive handling.
    
    Fixed-by: David Michael
    Closes: https://bugs.gentoo.org/734998
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-misc/pax-utils/pax-utils-1.2.6.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)