Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734916 - media-video/aegisub-9999 updates
Summary: media-video/aegisub-9999 updates
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nick Sarnie
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-31 07:50 UTC by Jan Seeger
Modified: 2020-08-05 16:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch for aegisub-9999. (patch,791 bytes, text/plain)
2020-07-31 07:50 UTC, Jan Seeger
Details
aegisub-9999 patch file (9999-wx-constructor.patch,2.28 KB, patch)
2020-07-31 07:51 UTC, Jan Seeger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Seeger 2020-07-31 07:50:19 UTC
Created attachment 651826 [details]
Ebuild patch for aegisub-9999.

I've made the aegisub git ebuild compile, seeing as the last release is about 4 years old by now.

I've had to patch some wxImage code, as it seems a constructor has been removed. Additionally, I've modified the build process to be single-threaded, as I've had strange errors when using a concurrent build. Also, I've added the '--disable-compiler-flags' flag to use the provided CFLAGS and CXXFLAGS. I've removed the provided luajit from the buildfile as well, and patched an autoconf feature check that was failing since it didn't select the C++ language before trying to compile stuff. 

Also fixed the 'make clean' target, which didn't work because there were dashes in the filenames. This isn't relevant for the ebuild though.
Comment 1 Jan Seeger 2020-07-31 07:51:09 UTC
Created attachment 651828 [details, diff]
aegisub-9999 patch file
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-31 09:38:43 UTC
Comment on attachment 651826 [details]
Ebuild patch for aegisub-9999.

Please send unified diffs (diff -u) next time. :-)
Comment 3 Nick Sarnie gentoo-dev 2020-07-31 19:41:23 UTC
Please create a pull request:

https://wiki.gentoo.org/wiki/Gentoo_GitHub
Comment 4 Jan Seeger 2020-08-03 13:07:46 UTC
Hello!

Cool, I didn't know this was possible. I've sent a pull request at https://github.com/gentoo/gentoo/pull/16973.
Comment 5 Larry the Git Cow gentoo-dev 2020-08-05 16:10:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1efe67d2c8cdc8ebbf688b587bd86146a054c60

commit f1efe67d2c8cdc8ebbf688b587bd86146a054c60
Author:     Jan Seeger <jan.seeger@thenybble.de>
AuthorDate: 2020-08-03 13:00:08 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2020-08-05 16:09:33 +0000

    media-video/aegisub-9999: Updated git ebuild.
    
    Closes: https://bugs.gentoo.org/734916
    Signed-off-by: Jan Seeger <jan.seeger@thenybble.de>
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 media-video/aegisub/aegisub-9999.ebuild          | 12 ++--
 media-video/aegisub/files/aegisub-9999-git.patch | 78 ++++++++++++++++++++++++
 2 files changed, 84 insertions(+), 6 deletions(-)