Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734786 - dev-python/jupyter_console-6.1.0 not installing jupyter-console script
Summary: dev-python/jupyter_console-6.1.0 not installing jupyter-console script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-30 15:22 UTC by Jan Seeger
Modified: 2020-08-28 08:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
jupyter_console-6.1.0-r1 ebuild patch. (patch,433 bytes, patch)
2020-07-30 15:22 UTC, Jan Seeger
Details | Diff
jupyter-console executable script (jupyter_console-6.1.0-jupyter-console,97 bytes, text/x-python)
2020-07-30 15:23 UTC, Jan Seeger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Seeger 2020-07-30 15:22:04 UTC
Created attachment 651690 [details, diff]
jupyter_console-6.1.0-r1 ebuild patch.

The upstream tarball is missing the /scripts folder, which means that the `jupyter-console` script will not be installed. This, in turn, will break running `jupyter console`. I've already reported an upstream bug at https://github.com/jupyter/jupyter_console/issues/222.

I've created an interim ebuild that copies the `jupyter-console` script into the `script` directory, which should fix the problem for now.
Comment 1 Jan Seeger 2020-07-30 15:23:31 UTC
Created attachment 651692 [details]
jupyter-console executable script
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-07-30 21:14:07 UTC
Nope, bundling scripts is not a solution.  Any reason they aren't using entry_points?  You could try replacing SRC_URI with github archive like many other Python ebuilds are doing.
Comment 3 Jan Seeger 2020-07-31 06:27:03 UTC
There's code using entry points in [setup.py](https://github.com/jupyter/jupyter_console/blob/c71ddd9e4a4d35ddaa7bb82a6065ecbc983d67c0/setup.py#L114), but only if setuptools is included. I don't know enough about python packaging to understand the full consequences of that (I /think/ setuptools will try and install dependencies?).

The script I've bundled hasn't changed from 6.0 and is only 3 lines, so I don't think bundling it is a major problem, but I'll try the github solution nonetheless.

Should this bug be a blocker to #734424?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-07-31 06:33:51 UTC
Oh my, what a silly logic.
Comment 5 Larry the Git Cow gentoo-dev 2020-07-31 06:38:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=545ae8944fe940a934a9d75f325309cca2b26963

commit 545ae8944fe940a934a9d75f325309cca2b26963
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-07-31 06:36:39 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-07-31 06:38:01 +0000

    dev-python/jupyter_console: Fix installing entry points
    
    Closes: https://bugs.gentoo.org/734786
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 ...jupyter_console-6.1.0.ebuild => jupyter_console-6.1.0-r1.ebuild} | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 6 Jan Seeger 2020-07-31 06:49:56 UTC
Cheers, thanks for fixing!
Comment 7 Jan Seeger 2020-08-28 08:16:35 UTC
Fixed in upstream: https://github.com/jupyter/jupyter_console/issues/222#issuecomment-682045458. Next release won't need the sed anymore.