Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734166 - sys-kernel/dracut with >=sys-apps/systemd-246_rc2 needs updated systemd services
Summary: sys-kernel/dracut with >=sys-apps/systemd-246_rc2 needs updated systemd services
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL: https://github.com/systemd/systemd/bl...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-28 04:42 UTC by Jason Chan
Modified: 2020-08-07 16:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Swapped out syslog for journal in StandardOutput and StandardError variables (dracut-050-Modernize-dracut-systemd-services-to-use-journal-ins.patch,5.85 KB, patch)
2020-07-28 04:43 UTC, Jason Chan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Chan 2020-07-28 04:42:26 UTC
Dracut's systemd services use type 'syslog' in the StandardError and StandardOutput variables. Systemd warns that 'syslog' has been obsoleted and to use 'journal' instead.

Reproducible: Always

Steps to Reproduce:
1. Emerge >=sys-apps/systemd-246_rc2 and any version of sys-kernel/dracut
2. systemctl daemon-reload
3. dmesg
Actual Results:  
[   11.405496] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-udev.service:27: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.405500] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-udev.service:28: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.405766] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-trigger.service:23: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.405770] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-trigger.service:24: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.406047] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-pivot.service:30: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.406050] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-pivot.service:31: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.406314] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-mount.service:22: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.406318] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-pre-mount.service:23: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.406562] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-mount.service:22: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.406566] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-mount.service:23: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.406786] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-initqueue.service:24: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.406789] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-initqueue.service:25: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.407005] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-cmdline.service:26: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
[   11.407008] systemd[1]: /usr/lib/dracut/modules.d/98dracut-systemd/dracut-cmdline.service:27: Standard output type syslog+console is obsolete, automatically updating to journal+console. Please update your unit file, and consider removing the setting altogether.
[   11.426520] systemd[1]: /lib/systemd/system/smartd.service:10: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

Expected Results:  
None of that

I've attached a patch that applies to version >=50 for dracut. It should be fine to apply with any version of systemd because they all support the 'journal' option.

It'd probably be better to use sed in the ebuild so it'd be compatible with dracut versions under 50.
Comment 1 Jason Chan 2020-07-28 04:43:32 UTC
Created attachment 651082 [details, diff]
Swapped out syslog for journal in StandardOutput and StandardError variables
Comment 2 Christian Bricart 2020-07-29 09:46:54 UTC
upstream PR: https://github.com/dracutdevs/dracut/pull/859
Comment 3 Christian Bricart 2020-07-29 09:59:18 UTC
IMHO rather than preliminary patching we should just wait for a new upstream version of dracut that has the proposed fix included, as it already is in upstream's queue.

Eventually there even will be such an updated version available once systemd 264 leaves RC and releases a GA version. Additionally, it will obviously take some further time to hit stable-$ARCH in Gentoo.

Until then, I think it is ok to keep those warnings for the people that explicitly opted-in for ~$ARCH
Comment 4 Jason Chan 2020-07-30 13:41:15 UTC
Thanks for the reply and PR link! I agree with waiting for upstream maintainers to deal with it, especially since dracut isn't the only project that would need to update it.

Good note on ~246 stabilization timing; I hadn't considered that it could be all fixed by then.
Comment 5 Larry the Git Cow gentoo-dev 2020-08-07 16:59:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ccf6576c110503b33b71af18649d54568fe208a

commit 0ccf6576c110503b33b71af18649d54568fe208a
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2020-08-05 00:18:41 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-08-07 16:59:23 +0000

    sys-kernel/dracut: Revbump 050, multiple upstream fixes
    
    * fix LVM activation
    * workaround for BTRFS mounts on slow machines
    * install NetworkManager initque/finished hook
    * POSIX shell compatibility fixes
    * remove deprecated "syslog" parameter from systemd units
    
    Closes: https://bugs.gentoo.org/724474
    Closes: https://bugs.gentoo.org/734166
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/17004

 sys-kernel/dracut/dracut-050-r2.ebuild             | 171 +++++++++++++++
 .../050-btrfs-force-preload-btrfs-module.patch     |  30 +++
 ...sh-quote-variables-in-parameter-expansion.patch | 111 ++++++++++
 ...lvm-fix-removal-of-pvscan-from-udev-rules.patch |  26 +++
 ...ager-ensure-that-nm-run.sh-is-executed-wh.patch |  48 ++++
 ...-systemd-remove-obsolete-syslog-parameter.patch | 241 +++++++++++++++++++++
 6 files changed, 627 insertions(+)