Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734092 - www-client/netsurf-3.10-r2 fails to build against <net-libs/libdom-0.4.1
Summary: www-client/netsurf-3.10-r2 fails to build against <net-libs/libdom-0.4.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Philipp Ammann
URL:
Whiteboard:
Keywords: PATCH
: 729014 834606 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-27 12:57 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2022-03-16 01:01 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log against libdom-0.4.0 (netsurf-3.10-libdom-0.4.0-build.log,82.06 KB, text/plain)
2020-07-27 12:57 UTC, Chí-Thanh Christopher Nguyễn
Details
Patch to the netsurf-3.10-r4 ebuild (netsurf.patch,566 bytes, patch)
2020-12-29 00:21 UTC, David Fellows
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2020-07-27 12:57:07 UTC
Created attachment 650980 [details]
build.log against libdom-0.4.0

Building www-client/netsurf-3.10-r2 against net-libs/libdom-0.3.3-r1 or 0.4.0 fails with the following error messages:

content/handlers/html/dom_event.c: In function ‘dom_SCRIPT_showed_up’:
content/handlers/html/dom_event.c:260:2: error: unknown type name ‘dom_html_scri
pt_element_flags’; did you mean ‘dom_html_script_element_h_’?
  260 |  dom_html_script_element_flags flags;
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |  dom_html_script_element_h_

content/handlers/html/html.c: In function ‘fire_dom_keyboard_event’:
content/handlers/html/html.c:187:8: warning: implicit declaration of function ‘d
om_keyboard_event_create’; did you mean ‘dom_keyboard_event_init’? [-Wimplicit-f
unction-declaration]
  187 |  exc = dom_keyboard_event_create(&evt);
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~
      |        dom_keyboard_event_init
content/handlers/html/html.c:187:8: warning: nested extern declaration of ‘dom_k
eyboard_event_create’ [-Wnested-externs]
content/handlers/html/html.c:195:37: error: macro "dom_keyboard_event_init" passed 14 arguments, but takes just 8
  195 |    false, false, false, false, false);
      |                                     ^
Comment 1 David Fellows 2020-12-29 00:21:50 UTC
Created attachment 680125 [details, diff]
Patch to the netsurf-3.10-r4 ebuild

This patch worked for me.  Actually, in my case libdom was not installed at all before attempting the emerge. Without the patch it is not built.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-16 00:04:23 UTC
*** Bug 729014 has been marked as a duplicate of this bug. ***
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-16 00:06:20 UTC
*** Bug 834606 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2022-03-16 01:01:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd26cff49f5f22d45512ef759025f5de665effdc

commit dd26cff49f5f22d45512ef759025f5de665effdc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-03-16 00:03:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-03-16 01:01:09 +0000

    www-client/netsurf: increase libdom lower bound; set DEPEND
    
    Closes: https://bugs.gentoo.org/734092
    Signed-off-by: Sam James <sam@gentoo.org>

 www-client/netsurf/netsurf-3.10-r4.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)