Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733768 - dev-libs/appstream does not have vala support in main tree
Summary: dev-libs/appstream does not have vala support in main tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest
: 927494 (view as bug list)
Depends on:
Blocks: 733834
  Show dependency tree
 
Reported: 2020-07-24 13:17 UTC by Dion Moult
Modified: 2025-02-12 22:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dion Moult 2020-07-24 13:17:01 UTC
Would it be possible to add vala support to appstream in the main tree? The appstream ebuild in the elementary overlay has this feature, and it looks straightforward:

https://data.gpo.zugaina.org/elementary/dev-libs/appstream/appstream-0.12.11.ebuild

Reproducible: Always

Steps to Reproduce:
1. emerge appstream
2.
3.
Actual Results:  
No vala

Expected Results:  
A useflag to enable vala

I tried modifying the ebuild to match the elementary overlay version, but I noticed that Gentoo installs valac/vapigen with a suffix of the version, so the build fails with saying "can't find vapigen", but perhaps someone with more experience in how Gentoo deals with Vala can sort this out :)
Comment 1 Andreas Sturmlechner gentoo-dev 2020-07-25 15:05:42 UTC
Nothing in tree requires requires vala support from dev-libs/appstream; plasma-workspace is the only consumer.
Comment 2 Dion Moult 2020-07-26 00:48:03 UTC
Oh - is the requirement that something in the tree needs it for this to be added? I was working on #733834 and that's why I ran into this. Is that enough justification?
Comment 3 Andreas Sturmlechner gentoo-dev 2020-07-26 12:17:39 UTC
(In reply to Dion Moult from comment #2)
> Oh - is the requirement that something in the tree needs it for this to be
> added? I was working on #733834 and that's why I ran into this. Is that
> enough justification?
It means that I accept patches from the one who needs this in appstream, and it can be added at the same time that this new package would be entering the repository, but I personally won't put energy into it - it's "gnome stuff".

You can look at dev-libs/libical for an example of vala support. I can't tell if it is a typical case though.
Comment 4 Andreas Sturmlechner gentoo-dev 2021-10-02 10:52:58 UTC
ping - would you like to add vala support to the ebuild via a PR?
Comment 5 Andreas Sturmlechner gentoo-dev 2021-11-29 18:05:40 UTC
gnome proj, are you interested at all, seeing gnome-extra/gnome-software is a revdep?
Comment 6 Joost Ruis 2022-05-17 21:44:48 UTC
Hey all. I was looking in pantheon-base/applications-menu from the elementary overlay. This requires vala support to be enabled on dev-libs/appstream too.

I'm uncertain about the quality of the ebuilds on that overlay, but I thought I would just mentions it on this bug.
Comment 7 Andreas Sturmlechner gentoo-dev 2024-03-25 14:31:17 UTC
*** Bug 927494 has been marked as a duplicate of this bug. ***
Comment 8 Larry the Git Cow gentoo-dev 2025-02-12 22:43:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f4dfac86983e48ce3acb3b7a5da4852e29b95cd

commit 1f4dfac86983e48ce3acb3b7a5da4852e29b95cd
Author:     Sarah Mia Leibbrand <Xavalia@gmail.com>
AuthorDate: 2025-01-27 17:23:02 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-12 22:40:44 +0000

    dev-libs/appstream: Add vala support
    
    Closes: https://bugs.gentoo.org/733768
    Signed-off-by: Sarah Mia Leibbrand <Xavalia@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40335
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/appstream/appstream-1.0.4.ebuild | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)