Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733654 - sys-libs/libseccomp-2.5.0 REQUIRED_USE of ${PYTHON_REQUIRED_USE} should be conditional on USE="python"
Summary: sys-libs/libseccomp-2.5.0 REQUIRED_USE of ${PYTHON_REQUIRED_USE} should be co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-23 17:17 UTC by Matt Whitlock
Modified: 2020-07-23 19:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2020-07-23 17:17:00 UTC
sys-libs/libseccomp-2.5.0 added Python support but overlooked a small detail: the occurrence of ${PYTHON_REQUIRED_USE} in REQUIRED_USE should be conditional on USE="python".


Actual:

REQUIRED_USE="${PYTHON_REQUIRED_USE}
	python? ( static-libs )"


Intended:

REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} static-libs )"


The difference is relevant for users like me who explicitly disable all PYTHON_TARGETS flags for packages configured with USE="-python", as a means of avoiding pointless remerges due to irrelevant changes in the profile default value of PYTHON_TARGETS.

On my system, 19 other installed packages with IUSE="python" put their ${PYTHON_REQUIRED_USE} inside a "python? ( … )" conditional block, and none specify it unconditionally.
Comment 1 Larry the Git Cow gentoo-dev 2020-07-23 19:53:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fa294e1567f4a0339eee057b392bdb605d549e3

commit 3fa294e1567f4a0339eee057b392bdb605d549e3
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-07-23 19:52:17 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-07-23 19:52:22 +0000

    sys-libs/libseccomp: Fixed REQUIRED_USE
    
    Thanks-to: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/733654
    Package-Manager: Portage-3.0.0, Repoman-2.3.23
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-libs/libseccomp/libseccomp-2.5.0.ebuild | 7 +++++--
 sys-libs/libseccomp/libseccomp-9999.ebuild  | 7 +++++--
 2 files changed, 10 insertions(+), 4 deletions(-)