Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733620 - <media-tv/mythtv-31 will not build due to patch files missing in portage
Summary: <media-tv/mythtv-31 will not build due to patch files missing in portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wilson M. Michaels
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-23 04:19 UTC by Ben
Modified: 2020-07-24 12:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2020-07-23 04:19:53 UTC
Hopefully not a duplicate but b.g.o is giving me a data error when searching for bugs.

In the mythtv-30.0_p20190808-r3 ebuild,

PATCHES=(
        "${FILESDIR}/${P}-respect_LDFLAGS.patch"
        "${FILESDIR}/${P}-cast_constants_to_short.patch"
        "${FILESDIR}/${P}-Fix_Dereferencing_type-punned_pointer.patch"
        "${FILESDIR}/${P}-Fix_unitialized_variables.patch"
        "${FILESDIR}/${PN}-29.1-Fix_create_webbrowser_window.patch"
        "${FILESDIR}/${P}-Include_QPainterPath.patch"
)

which implies there should be a version specific patch for each of these patches except for create_webbrowser_window.  However it looks like at least the 30 version for Include_QPainterPath no longer exists and was either deleted or renamed for the 0.31 version.

Should mythtv-30* and older ebuilds be deleted or should this be fixed back, resurrecting the 30 version of the patch files?
Comment 1 Wilson M. Michaels 2020-07-23 15:06:21 UTC
I see what I did wrong.  When I added the Include_QPainterPath.patch to mythtv-31 I noticed the was also relevant to version 30 and added it there as well using the wrong file name. The patch is not version specific.
Comment 2 Larry the Git Cow gentoo-dev 2020-07-24 12:03:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f79b391103fccf6a2aa4ca9cf39f1bdd3e93ae1

commit 7f79b391103fccf6a2aa4ca9cf39f1bdd3e93ae1
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2020-07-23 15:15:46 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-24 12:03:29 +0000

    media-tv/mythtv: Fix patch file reference name
    
    Closes: https://bugs.gentoo.org/733620
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Closes: https://github.com/gentoo/gentoo/pull/16789
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/mythtv/mythtv-30.0_p20190808-r3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)