Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733612 - app-emulation/qemu: 5.1 will have optional JACK dependency (needed for 9999?)
Summary: app-emulation/qemu: 5.1 will have optional JACK dependency (needed for 9999?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-22 23:12 UTC by SRH
Modified: 2020-08-25 22:24 UTC (History)
4 users (show)

See Also:
Package list:
media-sound/jack2
Runtime testing required: ---


Attachments
qemu-5.1.0 jack support (qemu-5.1.0-jack-support.patch,1.83 KB, patch)
2020-08-25 19:57 UTC, Ionen Wolkens
Details | Diff
qemu 5.1.0+9999 jack support (0001-app-emulation-qemu-add-jack-support.patch,3.34 KB, patch)
2020-08-25 20:22 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SRH 2020-07-22 23:12:05 UTC
QEMU 5.1 will be adding Jack audio passthrough as an alternative to PulseAudio or Alsa passthrough: https://github.com/qemu/qemu/blob/master/audio/jackaudio.c

Someone should test before adding the proper dependencies to the ebuild but media-sound/jack2 was the only primary dependency I needed when adding it to my own qemu-9999.ebuild


Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-07-22 23:18:51 UTC
Slow down, eh? 

It will need rekeywording but we have to add the dep first, and really, wait for the release.

It may need to be added to the live ebuild now though.
Comment 2 SRH 2020-07-22 23:25:57 UTC
> It may need to be added to the live ebuild now though.

Part of the reason for the bug report :) it's been in upstream QEMU for around roughly 2 months now
Comment 3 Ionen Wolkens gentoo-dev 2020-08-24 23:42:25 UTC
Would be nice if this was looked at given qemu-5.1.0 is released and in tree. I've briefly tried it and it works great when built with --audio-drv-list=jack + virtual/jack (r)dep (albeit only tested with jack2).
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2020-08-25 07:08:08 UTC
If you have a patch i can review it and 'git am' to ::gentoo tree.
Comment 5 Ionen Wolkens gentoo-dev 2020-08-25 19:57:48 UTC
Created attachment 656748 [details, diff]
qemu-5.1.0 jack support

(In reply to Sergei Trofimovich from comment #4)
> If you have a patch i can review it and 'git am' to ::gentoo tree.
Sure, just made one.

Used pulseaudio as reference to do the same so it "should" be fine as-is. Order-wise I think it makes most sense after pulseaudio but higher than the rest. static-libs aren't provided by jack so I blocked that. I've tested building against jack1 now and looks fine allowing virtual/jack to be used.
Comment 6 Ionen Wolkens gentoo-dev 2020-08-25 20:22:49 UTC
Created attachment 656752 [details, diff]
qemu 5.1.0+9999 jack support

Forgot to include -9999 in there so new version for completeness.
Comment 7 Larry the Git Cow gentoo-dev 2020-08-25 22:23:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e11a90081df511b04e286caad67d18d6fc45d664

commit e11a90081df511b04e286caad67d18d6fc45d664
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2020-08-25 20:18:54 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-08-25 22:23:50 +0000

    app-emulation/qemu: add jack support
    
    Closes: https://bugs.gentoo.org/733612
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-emulation/qemu/qemu-5.1.0.ebuild | 6 ++++--
 app-emulation/qemu/qemu-9999.ebuild  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 8 Sergei Trofimovich (RETIRED) gentoo-dev 2020-08-25 22:24:28 UTC
Looks perfect! Applied as is.

Thank you!