Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733234 - net-im/telegram-desktop-2.1.20 with USE -wayland forces USE wayland on mesa, gtk+ and qtgui
Summary: net-im/telegram-desktop-2.1.20 with USE -wayland forces USE wayland on mesa, ...
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: Georgy Yakovlev
URL: https://github.com/telegramdesktop/td...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-19 19:13 UTC by Anton Gubarkov
Modified: 2020-11-24 05:53 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
telegram-desktop-2.1.20-no-wayland.patch (telegram-desktop-2.1.20-no-wayland.patch,4.90 KB, patch)
2020-07-24 16:40 UTC, Attila Tóth
Details | Diff
telegram-desktop-2.1.20-r1.ebuild (telegram-desktop-2.1.20-r1.ebuild,4.20 KB, text/plain)
2020-07-24 16:42 UTC, Attila Tóth
Details
telegram-desktop-2.4.6-no-wayland.patch (telegram-desktop-2.4.6-no-wayland.patch,6.01 KB, patch)
2020-11-04 18:48 UTC, Attila Tóth
Details | Diff
telegram-desktop-2.4.6-r1.ebuild (telegram-desktop-2.4.6-r1.ebuild,4.79 KB, patch)
2020-11-04 18:49 UTC, Attila Tóth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Gubarkov 2020-07-19 19:13:29 UTC
The following USE changes are necessary to proceed:
 (see "package.use" in the portage(5) man page for more details)
# required by net-im/telegram-desktop-2.1.20::gentoo
# required by @selected
# required by @world (argument)
>=dev-qt/qtgui-5.15.0 wayland
# required by net-im/telegram-desktop-2.1.20::gentoo[gtk]
# required by @selected
# required by @world (argument)
>=x11-libs/gtk+-3.24.21 wayland
# required by x11-libs/gtk+-3.24.21::gentoo[wayland]
# required by net-im/telegram-desktop-2.1.20::gentoo[gtk]
# required by @selected
# required by @world (argument)
>=media-libs/mesa-20.1.3 wayland
# required by x11-libs/gtk+-3.24.21::gentoo[wayland]
# required by net-im/telegram-desktop-2.1.20::gentoo[gtk]
# required by @selected
# required by @world (argument)
>=x11-libs/libxkbcommon-0.10.0-r1 abi_x86_32


I wonder why [ebuild     U  ] net-im/telegram-desktop-2.1.20::gentoo [2.1.18::gentoo] USE="X alsa dbus gtk hunspell pulseaudio spell -enchant -libressl (-wayland%)"  should require wayland support in dependences.




P.S.
I have a hybrid GPU Thinkpad so the wayland is not an option for me I have to stick with X. I don't see why I should cloge my system with wayland dependencies.
Comment 1 TonCherAmi 2020-07-19 21:12:01 UTC
I have encountered this as well, it's really annoying. Please revert this change if possible.
Comment 2 Ionen Wolkens gentoo-dev 2020-07-20 12:39:50 UTC
Comparing 2.1.19 and 2.1.20, seems there was new non-optional checks added upstream (in Telegram/CMakeLists.txt) for qtwayland headers, so that the ebuild would add this seems unfortunately normal.

From commit:
https://github.com/telegramdesktop/tdesktop/commit/b587328fedaeea8fab34ce329ef8a687cb77238d

Shame it seems to be for something minor. Making it optional from this end would require patching and possibly long term support if upstream starts using this for more things.
Comment 3 Serghei Iakovlev 2020-07-20 15:48:03 UTC
In this case I'm forced to mask the current telegram version and stay on the previous one until wayland dependency becomes optional
Comment 4 Anton Gubarkov 2020-07-20 19:39:48 UTC
and to ice the cake they removed 2.1.18 from the portage tree. When I mask 2.1.20 portage forces me to downgrade to 2.1.13.

Keywords for net-im/telegram-desktop:
       |                             |   u   |
       | a   a     p s     a   r     |   n   |
       | m   r h   p p   s l i i m m | e u s | r
       | d a m p p c a x 3 p a s 6 i | a s l | e
       | 6 r 6 p p 6 r 8 9 h 6 c 8 p | p e o | p
       | 4 m 4 a c 4 c 6 0 a 4 v k s | i d t | o
-------+-----------------------------+-------+-------
2.1.13 | + o o o o ~ o o o o o o o o | 7 o 0 | gentoo
2.1.20 | ~ o o o o ~ o o o o o o o o | 7 o   | gentoo
Comment 5 Anton Gubarkov 2020-07-20 19:49:58 UTC
I've raised an issue upstream
https://github.com/telegramdesktop/tdesktop/issues/8282
Comment 6 Serghei Iakovlev 2020-07-20 20:23:48 UTC
(In reply to Anton Gubarkov from comment #5)
> I've raised an issue upstream
> https://github.com/telegramdesktop/tdesktop/issues/8282

Thank you!
Comment 7 Joonas Niilola gentoo-dev 2020-07-21 06:40:54 UTC
I wonder if the -bin version should be affected by this as well.

(In reply to Anton Gubarkov from comment #4)
> and to ice the cake they removed 2.1.18 from the portage tree. When I mask
> 2.1.20 portage forces me to downgrade to 2.1.13.

You can browse the git log, grab the ebuild and put it in your local overlay to get it back.
https://gitweb.gentoo.org/repo/gentoo.git/plain/net-im/telegram-desktop/telegram-desktop-2.1.18.ebuild?id=2719a1c2db7499e10895739210d13510a07ae3a5
https://wiki.gentoo.org/wiki/Custom_repository

Or you can git checkout your repository tree to the specific commit above, and emerge telegram-desktop normally, then --sync to latest state.
Comment 8 Georgy Yakovlev archtester gentoo-dev 2020-07-21 16:04:46 UTC
Please talk to upstream.

It does not seem they take this request seriously though.

I don't keep non-release versions of tdesktop in the tree, there's no point.

It's usually latest pre-release and and release builds, look here at tags: https://github.com/telegramdesktop/tdesktop/releases

Just use 2.1.13, it's the latest release and it works without wayland libs and deps, it will be around for couple more month at least.

-bin version will not be affected, because it just bundles everything statically inside single binary.


If upstream introduces a working -wayland switch I'll re-implement it in the ebuild asap.
Comment 9 Attila Tóth 2020-07-24 16:40:25 UTC
Created attachment 650594 [details, diff]
telegram-desktop-2.1.20-no-wayland.patch

Make Wayland optional again.
Comment 10 Attila Tóth 2020-07-24 16:42:04 UTC
Created attachment 650596 [details]
telegram-desktop-2.1.20-r1.ebuild

Coresponding ebuild keeps wayland optional, like before.
Comment 11 Larry the Git Cow gentoo-dev 2020-07-27 02:46:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3d07d38e909c3f19faa1c612b82baced0bcf242

commit f3d07d38e909c3f19faa1c612b82baced0bcf242
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-07-27 02:46:04 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-07-27 02:46:04 +0000

    net-im/telegram-desktop: don't require wayland for gtk+
    
    Bug: https://bugs.gentoo.org/733234
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 .../{telegram-desktop-2.2.0.ebuild => telegram-desktop-2.2.0-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 12 Georgy Yakovlev archtester gentoo-dev 2020-07-27 02:48:52 UTC
after talking with upstream I've removed gtk[wayland] dep.
seems with latest changes it should compile fine without wayland support in gtk, and should not require mesa with wayland, but still will pull mesa[egl]

so essentially ebuild now the only wayland dep is qtgui[wayland]
Comment 13 Konstantin Sobolev 2020-11-03 18:48:31 UTC
I just got it too. Is it the same issue?

The following USE changes are necessary to proceed:
 (see "package.use" in the portage(5) man page for more details)
# required by net-im/telegram-desktop-2.4.5::gentoo
# required by @selected
# required by @world (argument)
>=dev-qt/qtgui-5.15.1-r1 wayland
Comment 14 Georgy Yakovlev archtester gentoo-dev 2020-11-04 00:11:34 UTC
yes, it inconditionally requires wayland and qtwayland headers and will fail to build without those.

I'd gladly remove this dep if upstream did not force it.
Comment 15 Attila Tóth 2020-11-04 18:48:13 UTC
Created attachment 670025 [details, diff]
telegram-desktop-2.4.6-no-wayland.patch

Proposed patch for wayland-free build of a more recent telegram-desktop version.
Comment 16 Attila Tóth 2020-11-04 18:49:51 UTC
Created attachment 670028 [details, diff]
telegram-desktop-2.4.6-r1.ebuild

Proposed ebuild for wayland-free telegram-desktop build for a more recent version.
Comment 17 Larry the Git Cow gentoo-dev 2020-11-24 05:53:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2658014f512c0c931c80a95f40828a8af8fb67af

commit 2658014f512c0c931c80a95f40828a8af8fb67af
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-11-24 05:39:26 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-11-24 05:53:03 +0000

    net-im/telegram-desktop: bump to 2.4.11, make wayland optional
    
    Thanks-to:  Esteve Varela Colominas <esteve.varela@gmail.com>
    Bug: https://bugs.gentoo.org/733234
    Bug: https://bugs.gentoo.org/753737
    Package-Manager: Portage-3.0.10, Repoman-3.0.2
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-im/telegram-desktop/Manifest                                   | 2 +-
 ...elegram-desktop-2.4.9.ebuild => telegram-desktop-2.4.11.ebuild} | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)