Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733228 - sys-cluster/glusterfs-6.8: flock issue
Summary: sys-cluster/glusterfs-6.8: flock issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Cluster Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-19 14:43 UTC by Carlo
Modified: 2020-08-21 11:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlo 2020-07-19 14:43:30 UTC
Hi,

I faced https://bugzilla.redhat.com/show_bug.cgi?id=1776152 with glusterfs-6.8.

The named patch for 7 applies and fixes the issue.

Thanks.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-07-23 14:16:44 UTC
Including emerge --info would be nice additional information, thanks!
Comment 2 Jaco Kroon 2020-07-23 15:15:34 UTC
Carlo,

Any reason to not upgrade to 7.6?

One of the seeming various dupes upstreams are actually mine:

https://bugzilla.redhat.com/show_bug.cgi?id=1718562
Comment 3 Jaco Kroon 2020-07-23 16:03:08 UTC
Hey, before we get carried away, not fixed in 7.5, busy testing 7.6, but I'd rather we stick with upstream versions personally, glusterfs is definitely not something I'm comfortable with custom patching downstream unless we have no other choice, and then I want multiple reviewers.

I'd rather use this patch in any case, as per what was merged upstream:

https://review.gluster.org/#/c/glusterfs/+/23794/8/xlators/features/locks/src/common.c
Comment 4 Jaco Kroon 2020-07-23 18:07:43 UTC
Stock upstream 7.6 and 7.7 doesn't fix it either.

I've pushed a PR with a bump to 7.7, and including the relevant fix.  Confirmed working in my environment.
Comment 5 Larry the Git Cow gentoo-dev 2020-08-12 15:06:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=245ac0ef00c215baea76f892e04454434f87cbfc

commit 245ac0ef00c215baea76f892e04454434f87cbfc
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2020-08-12 15:06:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-08-12 15:06:14 +0000

    sys-cluster/glusterfs: version bump 7.7
    
    Include fix for flock.
    Drop seek fix that's included upstream.
    
    Bug: https://bugs.gentoo.org/733228
    
    Additional references:
    https://bugzilla.redhat.com/show_bug.cgi?id=1718562
    https://bugzilla.redhat.com/show_bug.cgi?id=1776152
    https://review.gluster.org/#/c/glusterfs/+/23794/8/xlators/features/locks/src/common.c
    
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/16790
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-cluster/glusterfs/Manifest                     |   1 +
 .../glusterfs/files/glusterfs-7.7-flock.patch      |  65 +++++++
 sys-cluster/glusterfs/glusterfs-7.7.ebuild         | 211 +++++++++++++++++++++
 3 files changed, 277 insertions(+)
Comment 6 Jaco Kroon 2020-08-12 16:36:00 UTC
Hi Carlo,

Are you able to confirm that the in-tree 7.7 fixes this for you?
Comment 7 Carlo 2020-08-20 12:34:58 UTC
Hi Jaco,

sorry for the delay, vacation...

I just checked it with in-tree 7.7. and can confirm that the issue is fixed.

Thanks!