Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732926 - app-antivirus/clamav: add RC init hook for clamonacc
Summary: app-antivirus/clamav: add RC init hook for clamonacc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Antivirus Team
URL: https://github.com/Cisco-Talos/clamav...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-07-16 16:39 UTC by James Ashdown
Modified: 2020-09-20 19:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
RC init script (clamd,3.75 KB, text/plain)
2020-07-16 16:39 UTC, James Ashdown
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Ashdown 2020-07-16 16:39:12 UTC
Created attachment 649574 [details]
RC init script

The OpenRC init script for clamd does not currently include support for launching clamonacc on startup. Here is an updated init script (clamd.initd) that correctly starts and stops clamonacc, and an optional change to configuration (clamd.conf) that makes clamonacc default.
Comment 1 Michael Orlitzky gentoo-dev 2020-07-16 20:44:33 UTC
Thanks... we unfortunately have a backlog of service script bugs. It would be trivial to add clamonacc support if clamd, freshclam, and the milter all had separate init scripts. They should, that's bug #272963.

I'm perfectly willing to separate the init scripts myself, but before I do that, clamav upstream is going to change the way they handle their PID file to fix a minor security issue. Once they do that, I can split up the scripts, and then we can add a proper clamonacc init script (which should only be a few trivial lines).

It would still be possible to split them right now, but you would have to jump through some tiny hoops to do it securely, and then of course redo all of that work after cisco changes the PID file handling. Not very attractive volunteer work.
Comment 2 Michael Orlitzky gentoo-dev 2020-08-18 14:27:40 UTC
I've prepared an upstream pull request for this (see $URL). If you can test it out, any feedback would be welcome!
Comment 3 Larry the Git Cow gentoo-dev 2020-09-20 19:35:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8038d96958974432777d667fae883516eebad258

commit 8038d96958974432777d667fae883516eebad258
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2020-09-20 17:08:41 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2020-09-20 19:28:56 +0000

    app-antivirus/clamav: new version 0.103.0.
    
    New version with lots of good stuff. The main changes are that
    on-access scanning is now controlled by USE=clamonacc, and that we
    provide separate OpenRC services for the various daemons.
    
    Closes: https://bugs.gentoo.org/272963
    Closes: https://bugs.gentoo.org/670729
    Closes: https://bugs.gentoo.org/732926
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 app-antivirus/clamav/Manifest                      |   1 +
 app-antivirus/clamav/clamav-0.103.0.ebuild         | 219 ++++++++++
 .../files/clamav-0.103.0-system-tomsfastmath.patch | 115 ++++++
 .../files/clamav-0.103.0-upstream-openrc.patch     | 447 +++++++++++++++++++++
 app-antivirus/clamav/metadata.xml                  |   1 +
 5 files changed, 783 insertions(+)