Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732776 - sci-mathematics/maxima-5.44.0: doesn't build library for ecl anymore
Summary: sci-mathematics/maxima-5.44.0: doesn't build library for ecl anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Science Mathematics related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-15 18:53 UTC by gordon
Modified: 2021-03-25 14:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gordon 2020-07-15 18:53:28 UTC
It looks like 5.44.0 ebuild doesn't build maxima library for ecls anymore and that makes it impossible to use it in ecls.

Reproducible: Always

Steps to Reproduce:
1. install maxima-5.44.0
2. run ecl
3. type "(require 'maxima)" there
Actual Results:  
> (require 'maxima)

Condition of type: SIMPLE-ERROR
Module error: Don't know how to REQUIRE MAXIMA.

Available restarts:

1. (RESTART-TOPLEVEL) Go back to Top-Level REPL.

Broken at SI:BYTECODES. [Evaluation of: (REQUIRE 'MAXIMA)] In: #<process TOP-LEVEL>.


Expected Results:  
> (require 'maxima)
("MAXIMA")


--- maxima-5.43.2.ebuild        2020-04-07 16:39:39.000000000 +0100
+++ maxima-5.44.0.ebuild        2020-06-08 15:39:04.000000000 +0100
@@ -20,7 +20,7 @@
 # . - just --enable-<lisp>, <flag> - --enable-<flag>
 CONF_FLAG=( .    .     .               ecl  ccl       .     )
 # patch file version; . - no patch
-PATCH_V=(   2    1     .               3    3         1     )
+PATCH_V=(   2    1     .               .    3         1     )

 IUSE="emacs tk nls unicode X test ${LISPS[*]}"
 RESTRICT="!test? ( test )"
@@ -97,7 +97,7 @@

 src_prepare() {
        local n PATCHES v
-       PATCHES=( emacs-0 rmaxima-0 wish-2 xdg-utils-1 texinfo-0 )
+       PATCHES=( emacs-0 rmaxima-0 wish-2 xdg-utils-1 )

        n=${#PATCHES[*]}
        for ((n--; n >= 0; n--)); do
@@ -188,13 +188,6 @@
                doins interfaces/emacs/imaxima/README
                doins -r interfaces/emacs/imaxima/imath-example
        fi
-
-       # if we use ecls, build an ecls library for maxima
-       if use ecls; then
-               ECLLIB=`ecl -eval "(princ (SI:GET-LIBRARY-PATHNAME))" -eval "(quit)"`
-               insinto "${ECLLIB#${EPREFIX}}"
-               doins src/binary-ecl/maxima.fas
-       fi
 }

 pkg_postinst() {


I assume culprit is second block being removed.
Stops sci-mathematics/sage from sage-on-gentoo overlay from being able to use maxima.

Tried maxima-5.43.2 and it works as expected.
Comment 1 Andrey Grozin gentoo-dev 2020-07-22 16:02:58 UTC
The old patch for building the library with ecls no longer applies. I don't know ecls well enough to construct a new patch. If you want this library, please, send me a patch.
Comment 2 Michael Orlitzky gentoo-dev 2021-03-16 21:05:39 UTC
François has a fix for this and, I think, some other issues in the sage-on-gentoo overlay. Shall we merge some of them?
Comment 3 François Bissey 2021-03-16 21:13:48 UTC
Indeed I do. Feel free to plunder. As far as I remember I had to fix numerous issues in ecls-20.4.24 first to make it work. A preliminary draft for the main tree was at https://github.com/gentoo/gentoo/pull/16725. All those fixes are not needed anymore in the new ecls.

The patch is otherwise really small. Beside that I still carry a couple of patches from sage that seem to get no traction in upstream maxima.
Comment 4 Larry the Git Cow gentoo-dev 2021-03-25 14:38:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99d068bcd512389b60a972d53c95f22571ed3537

commit 99d068bcd512389b60a972d53c95f22571ed3537
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2021-03-24 21:35:49 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-03-25 14:35:26 +0000

    sci-mathematics/maxima: re-enable ECL package.
    
    The ECL package needed for USE=ecls got dropped from the ebuild
    because the patch it requires no longer applied. We take François
    Bissey's patch from the sage-on-gentoo overlay and re-enable it.
    
    Closes: https://bugs.gentoo.org/732776
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/maxima/files/ecls-4.patch            | 16 ++++++++++++++++
 ...{maxima-5.44.0.ebuild => maxima-5.44.0-r1.ebuild} | 20 +++++++++++++++++---
 2 files changed, 33 insertions(+), 3 deletions(-)