Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732712 - www-client/firefox: depends on gold linker when it doesn't need to
Summary: www-client/firefox: depends on gold linker when it doesn't need to
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-15 07:49 UTC by Joonmo Yang
Modified: 2020-09-30 02:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonmo Yang 2020-07-15 07:49:28 UTC
It seems that firefox uses lld when clang is used as a compiler, but the package dependency states that I need both gold(from llvm[gold]) and lld if [clang] flag is turned on.
I think the gold linker can be safely removed from DEPEND when the [clang] flag is enabled.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2020-07-15 07:59:43 UTC
I've auto-removed [gold] from the ebuild since firefox-69.* or so myself, and have llvmgold is not installed (also -gold on binutils)

I know it _did_ use to be needed but I'm not sure anymore.

Firefox does have a bundled LLVMgold.so.zip though (maaaaybe it's getting used when normally you'd want the system's? not sure though), so I kinda suspected there could be something more going on so I never opened a bug.
Comment 2 Larry the Git Cow gentoo-dev 2020-09-30 02:16:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d523c2051222bb5ab591efe8f1abc03508bdc4d5

commit d523c2051222bb5ab591efe8f1abc03508bdc4d5
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-09-30 02:16:14 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-09-30 02:16:49 +0000

    www-client/firefox: fix gold linker deps
    
    Closes: https://bugs.gentoo.org/732712
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-78.3.0.ebuild | 9 +++++----
 www-client/firefox/firefox-81.0.ebuild   | 9 +++++----
 2 files changed, 10 insertions(+), 8 deletions(-)