Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732540 - gnome-extra/gnome-contacts-3.36.2[telepathy]: contacts-utils.vala:83: The type name `Contact' could not be found
Summary: gnome-extra/gnome-contacts-3.36.2[telepathy]: contacts-utils.vala:83: The typ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/gnome-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-14 10:23 UTC by Bernd Feige
Modified: 2020-12-19 11:55 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_732540.txt,7.88 KB, text/plain)
2020-07-27 14:38 UTC, Jan Vesely
Details
build.log (build.log,10.86 KB, text/plain)
2020-07-27 14:38 UTC, Jan Vesely
Details
emerge --info (emerge.info,8.73 KB, application/x-info)
2020-08-24 03:33 UTC, MrSnivvel
Details
telepathy_contacts.patch (telepathy_contacts.patch,2.18 KB, patch)
2020-12-01 12:47 UTC, Luide Capanema dos Santos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2020-07-14 10:23:55 UTC
Compilation with +telepathy fails in a part of the code only reached with this USE flag. This seems to be a case of bitrot given that telepathy was removed from default builds (and CI testing) a year ago (cf. https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/103).

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-07-23 14:07:36 UTC
Could you include the build.log and emerge --info? Thanks.
Comment 2 Jan Vesely 2020-07-27 14:38:22 UTC
Created attachment 651002 [details]
emerge --info

I can reproduce on my setup as well. emerge --info attached
Comment 3 Jan Vesely 2020-07-27 14:38:56 UTC
Created attachment 651004 [details]
build.log

build.log
Comment 4 MrSnivvel 2020-08-24 03:33:25 UTC
Created attachment 656390 [details]
emerge --info

Removing the 'telepathy' USE flag worked for me also.
Comment 5 m1027 2020-08-31 16:10:49 UTC
Same here.

Removing -telepathy from USE works but might be required for e.g. empathy.
Comment 6 Luide Capanema dos Santos 2020-12-01 12:45:21 UTC
apply this patch and test:

"
--- gnome-contacts-3.36.2/src/contacts-contact-list.vala	2020-06-19 08:45:08.116728500 -0300
+++ /tmp/contacts-contact-list.vala	2020-12-01 09:31:25.894985426 -0300
@@ -243,7 +243,7 @@
     selection_changed (individual);
 #if HAVE_TELEPATHY
     if (individual != null)
-      Contact.fetch_contact_info (individual);
+      Utils.fetch_contact_info (individual);
 #endif
   }
 
--- gnome-contacts-3.36.2/src/contacts-contact-sheet.vala	2020-06-19 08:45:08.116728500 -0300
+++ /tmp/contacts-contact-sheet.vala	2020-12-01 09:34:13.683604120 -0300
@@ -27,6 +27,7 @@
 public class Contacts.ContactSheet : Grid {
   private int last_row = 0;
   private Individual individual;
+  private unowned Store store;
   public bool narrow { get; set; default = true; }
 
   private const string[] SORTED_PROPERTIES = {
@@ -43,6 +44,7 @@
   public ContactSheet (Individual individual, Store store) {
     Object (row_spacing: 12, column_spacing: 12);
     this.individual = individual;
+    this.store = store;
 
     this.individual.notify.connect (update);
     this.individual.personas_changed.connect (update);
@@ -242,7 +244,7 @@
                 var type = im_persona.presence_type;
                 if (type != PresenceType.UNSET && type != PresenceType.ERROR &&
                     type != PresenceType.OFFLINE && type != PresenceType.UNKNOWN) {
-                  Utils.start_chat (this.contact, protocol, id.value);
+                  Utils.start_chat (this.individual, protocol, id.value);
                 }
               }
             });
--- gnome-contacts-3.36.2/src/contacts-utils.vala	2020-06-19 08:45:08.120728500 -0300
+++ /tmp/contacts-utils.vala	2020-12-01 09:35:46.319945702 -0300
@@ -80,8 +80,8 @@
   }
 
 #if HAVE_TELEPATHY
-  public void start_chat (Contact contact, string protocol, string id) {
-    var im_persona = contact.find_im_persona (protocol, id);
+  public void start_chat (Individual individual, string protocol, string id) {
+    var im_persona = Utils.find_im_persona (individual, protocol, id);
     var account = (im_persona.store as Tpf.PersonaStore).account;
     var request_dict = new HashTable<string, Value?>(str_hash, str_equal);
     request_dict.insert (TelepathyGLib.PROP_CHANNEL_CHANNEL_TYPE,

"
thanks
Comment 7 Luide Capanema dos Santos 2020-12-01 12:47:40 UTC
Created attachment 676009 [details, diff]
telepathy_contacts.patch
Comment 8 Larry the Git Cow gentoo-dev 2020-12-19 11:55:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a4227497860654f320ebfd6925846e6a21608d4

commit 3a4227497860654f320ebfd6925846e6a21608d4
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2020-12-19 11:50:50 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2020-12-19 11:53:13 +0000

    gnome-extra/gnome-contacts: fix build with USE=telepathy
    
    Also require at least vala-0.40, as compilation fails with 0.36.
    gnome-contacts-3.38 adds a meson check for >=vala-0.40.10 too.
    
    Closes: https://bugs.gentoo.org/732540
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 .../files/3.36.2-fix-telepathy.patch               | 71 ++++++++++++++++++++++
 .../gnome-contacts/gnome-contacts-3.36.2.ebuild    |  5 ++
 2 files changed, 76 insertions(+)