Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732384 - xfce-extra/xfce4-hdaps-1.0.0 : xfce4-hdaps.c: error: expected expression before HdapsPlugin
Summary: xfce-extra/xfce4-hdaps-1.0.0 : xfce4-hdaps.c: error: expected expression befo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
: 769545 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-12 21:38 UTC by Toralf Förster
Modified: 2021-02-08 20:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.21 KB, text/plain)
2020-07-12 21:38 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,109.77 KB, text/plain)
2020-07-12 21:38 UTC, Toralf Förster
Details
environment (environment,21.96 KB, text/plain)
2020-07-12 21:38 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,12.84 KB, application/x-bzip)
2020-07-12 21:38 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,11.00 KB, application/x-bzip)
2020-07-12 21:38 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,11.23 KB, application/x-bzip)
2020-07-12 21:38 UTC, Toralf Förster
Details
xfce-extra:xfce4-hdaps-1.0.0:20200712-175005.log (xfce-extra:xfce4-hdaps-1.0.0:20200712-175005.log,26.91 KB, text/plain)
2020-07-12 21:38 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-07-12 21:38:09 UTC
      |           ^~~~~~~~~~~~~~~~
      |           g_slice_new0
xfce4-hdaps.c:238:28: error: expected expression before ‘HdapsPlugin’
  238 |   hdaps = panel_slice_new0(HdapsPlugin);
      |                            ^~~~~~~~~~~
xfce4-hdaps.c: In function ‘hdaps_free’:

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma-20200708-161646

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.1.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.9 (fallback)
  [3]   python3.8 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.44.1 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.16.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sun 12 Jul 2020 05:05:23 PM UTC

emerge -qpvO xfce-extra/xfce4-hdaps
[ebuild  N    ] xfce-extra/xfce4-hdaps-1.0.0
Comment 1 Toralf Förster gentoo-dev 2020-07-12 21:38:12 UTC
Created attachment 649030 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-07-12 21:38:15 UTC
Created attachment 649032 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-07-12 21:38:18 UTC
Created attachment 649034 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-07-12 21:38:21 UTC
Created attachment 649036 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-07-12 21:38:24 UTC
Created attachment 649038 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-07-12 21:38:26 UTC
Created attachment 649040 [details]
temp.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-07-12 21:38:29 UTC
Created attachment 649042 [details]
xfce-extra:xfce4-hdaps-1.0.0:20200712-175005.log
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-07 20:43:01 UTC

*** This bug has been marked as a duplicate of bug 732754 ***
Comment 9 Michael Orlitzky gentoo-dev 2021-02-08 00:55:52 UTC
Please try with the new 1.0.1, I think I just needed to replace "panel_slice_new0" with "g_slice_new0". The old one was deprecated, but you know, without a deprecation warning.
Comment 10 Larry the Git Cow gentoo-dev 2021-02-08 01:00:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd8c8573f60cde6763878fdc6c8ef429731a6d04

commit fd8c8573f60cde6763878fdc6c8ef429731a6d04
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2021-02-08 00:58:44 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-02-08 00:58:44 +0000

    profiles: unmask xfce-extra/xfce4-hdaps.
    
    The new v1.0.1 should build against xfce-4.16, and I've added myself
    as a maintainer of the package.
    
    Bug: https://bugs.gentoo.org/732384
    Bug: https://bugs.gentoo.org/732754
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 profiles/package.mask | 1 -
 1 file changed, 1 deletion(-)
Comment 11 Michael Orlitzky gentoo-dev 2021-02-08 01:00:54 UTC
Please try with the new 1.0.1, I think I just needed to replace "panel_slice_new0" with "g_slice_new0". The old one was deprecated, but you know, without a deprecation warning.
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-08 08:35:03 UTC
1.0.1 still fails:

xfce4-hdaps.c:44:1: warning: data definition has no type or storage class
   44 | XFCE_PANEL_PLUGIN_REGISTER(hdaps_construct);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
xfce4-hdaps.c:44:1: warning: type defaults to ‘int’ in declaration of ‘XFCE_PANEL_PLUGIN_REGISTER’ [-Wimplicit-int]
xfce4-hdaps.c:44:1: warning: parameter names (without types) in function declaration
xfce4-hdaps.c: In function ‘hdaps_free’:
xfce4-hdaps.c:314:3: warning: implicit declaration of function ‘panel_slice_free’; did you mean ‘g_slice_free’? [-Wimplicit-function-declaration]
  314 |   panel_slice_free(HdapsPlugin, hdaps);
      |   ^~~~~~~~~~~~~~~~
      |   g_slice_free
xfce4-hdaps.c:314:20: error: expected expression before ‘HdapsPlugin’
  314 |   panel_slice_free(HdapsPlugin, hdaps);
      |                    ^~~~~~~~~~~
Comment 13 Larry the Git Cow gentoo-dev 2021-02-08 12:36:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=20d07dc537a3cace0c230a20d2ff74cb4dd0e1e1

commit 20d07dc537a3cace0c230a20d2ff74cb4dd0e1e1
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2021-02-08 12:34:57 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-02-08 12:34:57 +0000

    xfce-extra/xfce4-hdaps: new version to fix building against xfce-4.16.
    
    Bug: https://bugs.gentoo.org/732384
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 xfce-extra/xfce4-hdaps/Manifest                                         | 2 +-
 .../xfce4-hdaps/{xfce4-hdaps-1.0.1.ebuild => xfce4-hdaps-1.0.2.ebuild}  | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 14 Michael Orlitzky gentoo-dev 2021-02-08 12:38:15 UTC
I can still guess at this and re-release a few more times before it would have been faster to update my laptop to 4.16.

It sure would be nice if the list of removed macros was in the libxfce4panel changelog.
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-08 18:13:54 UTC
libtool: link:  x86_64-pc-linux-gnu-gcc-10.2.0 -shared  -fPIC -DPIC  .libs/libhdaps_la-hdaps.o .libs/libhdaps_la-xfce4-hdaps.o .libs/libhdaps_la-xfce4-hdaps-dialogs.o   -lxfce4ui-2 -lxfce4panel-2.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lxfce4util -lglib-2.0  -pthread -pthread -march=znver2 -O2 -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,--export-dynamic -pthread   -pthread -Wl,-soname -Wl,libhdaps.so -Wl,-version-script -Wl,.libs/libhdaps.ver -o .libs/libhdaps.so
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld:.libs/libhdaps.ver:2: syntax error in VERSION script
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:527: libhdaps.la] Error 1



$ cat /tmp/portage/xfce-extra/xfce4-hdaps-1.0.2/work/xfce4-hdaps-1.0.2/panel-plugin/.libs/libhdaps.ver 
{ global:
local: *; };
Comment 16 Michael Orlitzky gentoo-dev 2021-02-08 18:42:14 UTC
This looks the same as bug #730886. Let's try to randomly rename header files. v1.0.3 incoming.
Comment 17 Michael Orlitzky gentoo-dev 2021-02-08 18:45:42 UTC
*** Bug 769545 has been marked as a duplicate of this bug. ***
Comment 18 Michael Orlitzky gentoo-dev 2021-02-08 18:52:02 UTC
Firefox changed the way selection works in the address bar after 20 years, so this is how I reference bugs now:

commit b4c875126dfb5004a2d3c859357872251756f86f (HEAD -> master, origin/master,$
Author: Michael Orlitzky <mjo@gentoo.org>
Date:   Mon Feb 8 13:46:56 2021 -0500

    xfce-extra/xfce4-hdaps: yet another new version for xfce-4.16 compat.

    Bug: https://bugs.gentoo.org/
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
Comment 19 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-02-08 19:44:00 UTC
The new new new version seems to finally work.
Comment 20 Michael Orlitzky gentoo-dev 2021-02-08 20:29:34 UTC
Haha, thanks for the help.