Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732222 - dev-lang/rust: depends on curl with http2 support
Summary: dev-lang/rust: depends on curl with http2 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 709568
  Show dependency tree
 
Reported: 2020-07-11 14:08 UTC by David Michael
Modified: 2020-09-08 03:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-07-11 14:08:26 UTC
When building Rust, it compiles the curl-sys crate.  This crate has a test that causes it to ignore the system curl and compile a builtin static version if it can't detect HTTP2 support.

https://github.com/alexcrichton/curl-rust/blob/master/curl-sys/build.rs#L482-L505

Can the dependency be changed to require this configuration so that it uses the system curl consistently?

(This is not high priority, so I'll just force USE=http2 locally if this isn't something that should be a hard-coded dependency ... and I'll live with the fact that in sysroot builds, build.rs links against the library in the sysroot but tests /usr/bin/curl-config for HTTP2 support.)

Reproducible: Always




--- a/dev-lang/rust/rust-1.44.1.ebuild
+++ b/dev-lang/rust/rust-1.44.1.ebuild
@@ -65,7 +65,7 @@
 	>=dev-libs/libgit2-0.99:=
 	net-libs/libssh2:=
 	net-libs/http-parser:=
-	net-misc/curl:=[ssl]
+	net-misc/curl:=[http2,ssl]
 	sys-libs/zlib:=
 	!libressl? ( dev-libs/openssl:0= )
 	libressl? ( dev-libs/libressl:0= )
Comment 1 Georgy Yakovlev archtester gentoo-dev 2020-07-11 17:47:38 UTC
good catch.

amazing that most of the -sys crate problems come from the same source.

I'll add it on next bump.
Comment 2 David Michael 2020-07-17 14:04:47 UTC
This is still an issue with dev-lang/rust-1.45.0.
Comment 3 Georgy Yakovlev archtester gentoo-dev 2020-07-17 17:42:41 UTC
thanks for checking, unfortunately I've lost some changes saved in git stash...
Comment 4 Larry the Git Cow gentoo-dev 2020-07-24 23:36:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2c2eddbfdcc2f3e6dbccdb99b13f45d3c2f74ad

commit b2c2eddbfdcc2f3e6dbccdb99b13f45d3c2f74ad
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-07-24 23:35:34 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-07-24 23:36:06 +0000

    dev-lang/rust: depend on curl[http2]
    
    No revbump, spare users a rebuild.
    
    Bug: https://bugs.gentoo.org/732222
    Package-Manager: Portage-3.0.0, Repoman-2.3.23
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-lang/rust/rust-1.45.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Georgy Yakovlev archtester gentoo-dev 2020-07-24 23:37:08 UTC
leaving open until next stable lands.
Comment 6 Mart Raudsepp gentoo-dev 2020-08-08 09:13:16 UTC
Please actually arrange for curl to default enable USE=http2 then with its maintainer, so that users don't need to immediately add package.use entries when they need to install librsvg or firefox.
Or alternatively, do I to fix this only for gnome profiles?
Comment 7 Mart Raudsepp gentoo-dev 2020-08-14 20:13:20 UTC
(In reply to Mart Raudsepp from comment #6)
> Please actually arrange for curl to default enable USE=http2 then with its
> maintainer, so that users don't need to immediately add package.use entries
> when they need to install librsvg or firefox.
> Or alternatively, do I to fix this only for gnome profiles?

blueness has done this with curl ebuild IUSE default in bug 736744 before requesting stabilization
Comment 8 Georgy Yakovlev archtester gentoo-dev 2020-09-08 03:55:44 UTC
1.45.2 stable
curl defaults to [http2] useflag.
thanks all, closing.