Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732172 - app-misc/solaar: Consider using python-single-r1.eclass
Summary: app-misc/solaar: Consider using python-single-r1.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-11 08:59 UTC by Mart Raudsepp
Modified: 2021-02-27 19:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2020-07-11 08:59:05 UTC
Solaar is an end-user application that doesn't have any consumers of it in the tree, so there should be no need to have it installed with multiple python versions.
Therefore please consider making it PYTHON_SINGLE_TARGET instead of PYTHON_TARGETS via setting DISTUTILS_SINGLE_IMPL=1 before inheriting distutils-r1 and wrapping the PYTHON_USEDEP dependencies around the appropriate python_gen_cond_dep


You are also missing introspection USE dependency on the libappindicator and libnotify deps - solaar imports them at runtime, just having them there without introspection isn't enough.

There are also these QA warnings:

 * DISTUTILS_USE_SETUPTOOLS value is probably incorrect
 *   value:    DISTUTILS_USE_SETUPTOOLS=no
 *   expected: DISTUTILS_USE_SETUPTOOLS=bdepend
Comment 1 Larry the Git Cow gentoo-dev 2021-02-27 19:26:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=72b0331ed080bebd6dc76534540bb8f96c0f0461

commit 72b0331ed080bebd6dc76534540bb8f96c0f0461
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-02-27 19:22:25 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-02-27 19:26:10 +0000

    app-misc/solaar: Convert to PYTHON_SINGLE_TARGET
    
    ... and fix libnotify/libappindicator dependencies and add Python 3.9
    compatibility and sync from 1.0.3_rc1. Sigh.
    
    Closes: https://bugs.gentoo.org/732172
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 app-misc/solaar/solaar-9999.ebuild | 38 +++++++++++++++++++++++++-------------
 1 file changed, 25 insertions(+), 13 deletions(-)