This line, "dosym login /etc/pam.d/${PN}" is present in both -11 and -13 ebuild versions of this package. Looks like it was added with, https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=988725bd499ebb17022bffbcfaeb32f6b36bc5d6 but not explained properly. It looks weird, why not just use /etc/pam.d/login? Can you figure out whether it's needed or not, and add a comment with link to upstream explaining why this was added?
Upstream recommends having a physlock specific PAM config here: https://github.com/muennich/physlock/commit/66957ee48384dd2e0fa6477b8276e9f6b3842bc5 There is also a sample `physlock.pam` file distributed which should work. Maybe we should use that one instead.
You'll have to test that it works. But yes, it looks smarter.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d4cf4dbe1e99ecf5cc13e65d41cf7445455a8b3 commit 6d4cf4dbe1e99ecf5cc13e65d41cf7445455a8b3 Author: toshokan <toshokan@shojigate.net> AuthorDate: 2020-07-09 15:43:30 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-07-11 08:18:37 +0000 app-misc/physlock: Use upstream PAM config Following the recommendation at https://github.com/muennich/physlock/commit/66957ee48384dd2e0fa6477b8276e9f6b3842bc5 Also more closely follow the configuration format the build system expects. Package-Manager: Portage-2.3.103, Repoman-2.3.23 Closes: https://bugs.gentoo.org/731824 Signed-off-by: Jason Pizzuco <toshokan@shojigate.net> Closes: https://github.com/gentoo/gentoo/pull/16649 Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-misc/physlock/physlock-13-r1.ebuild | 41 +++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
