Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 731820 - dev-libs/libffi-3.3-r2[test-bhaible]: USE flag necessity unclear?
Summary: dev-libs/libffi-3.3-r2[test-bhaible]: USE flag necessity unclear?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-09 06:24 UTC by Joonas Niilola
Modified: 2020-07-16 20:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2020-07-09 06:24:24 UTC
Hey, 

so when doing world updates I saw this in my list: 

  [ebuild     U  ] dev-libs/libffi-3.3-r2:0/7::gentoo [3.3-r1:0/7::gentoo] USE="test-bhaible* -debug -pax_kernel -static-libs -test" ABI_X86="32 (64) (-x32)" 1,275 KiB

  >: equery u libffi
   + - test-bhaible : Run extended regression tests (very slow).

From what I understand, this is not run unless FEATURES="test" is enabled. But just seeing this weird USE flag enabled made me dig into it, and just in case disable it via package.use.

So my question is: Shouldn't this be ran anytime FEATURES="test" is used, regardless of the USE flag? I'm most likely not the only one wondering what's going on here.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-07-09 06:43:42 UTC
Testsuite is very slow and you might want to opt out of running it on a daily basis if you just need to smoke-test libffi.

USE-flag description tries to hint at that:
    <flag name="test-bhaible">Run extended regression tests (very slow).</flag>
Comment 2 Ionen Wolkens gentoo-dev 2020-07-09 08:12:22 UTC
Made me wonder as well. I checked the USE description "huh, that sounds nasty.. why? I don't want to run any tests", looked up the commit message, had a look at the ebuild, and moved on seeing it's doing nothing on its own, but it's a process I wouldn't wish on other users.

Maybe the USE description should at least be changed?
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2020-07-09 17:30:15 UTC
Do you have an example wording?
Comment 4 Larry the Git Cow gentoo-dev 2020-07-16 20:55:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e661f90fa8cf2d221d84ba48e15ac116d78b3d6

commit 4e661f90fa8cf2d221d84ba48e15ac116d78b3d6
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-07-16 20:53:19 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-07-16 20:53:39 +0000

    dev-libs/libffi: drop USE=test-bhaible
    
    Run full testsuite unconditionally.
    
    Reported-by: Joonas Niilola
    Closes: https://bugs.gentoo.org/731820
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-libs/libffi/libffi-3.3-r1.ebuild | 11 +----------
 dev-libs/libffi/libffi-3.3-r2.ebuild | 11 +----------
 dev-libs/libffi/metadata.xml         |  1 -
 3 files changed, 2 insertions(+), 21 deletions(-)