Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 731306 - net-misc/rsync-3.2.2 : rsync: --bwlimit value is too small: 0 // rsync error: syntax or usage error (code 1) at main.c(1694) [client=3.2.2]
Summary: net-misc/rsync-3.2.2 : rsync: --bwlimit value is too small: 0 // rsync error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-07 18:59 UTC by foufou33
Modified: 2020-07-28 06:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description foufou33 2020-07-07 18:59:21 UTC
this commit https://github.com/WayneD/rsync/commit/11eb67eec9b4d990ae4df680cf7db77dad1b8630 broke --bwlimit=0  (say 3.2.2 but I'm not sur if it was broken before that all I know is I noticed after an upgrade  to 3.2.2 from 3.1.3 I think)

Reproducible: Always

Steps to Reproduce:
1. $ rsync  --bwlimit=0  /source/ /dest/
Actual Results:  
rsync: --bwlimit value is too small: 0
 rsync error: syntax or usage error (code 1) at main.c(1694) [client=3.2.2]

Expected Results:  
sync bwtwin src and dest

it has been reported and frixed upstream
https://github.com/WayneD/rsync/issues/51

the fix: 
https://github.com/WayneD/rsync/commit/5dcb49c7ddec765d4a24b4f801ffc7212c085db1
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-09 10:28:36 UTC
The manual page for 3.2.0 says the RATE is "specified in units per second". 0 (zero) units per second makes no sense but the manual specifies that in that case the value is interpreted as having no limit: "A value of zero specifies no limit." (i.e. disabling bandwidth limits).

The 3.2.2 manual says exactly the same thing, so either this is upstream changing the interface and forgetting to update the manual, or they actually broke it. :)
Comment 2 foufou33 2020-07-09 18:53:47 UTC
it was broken, they fixed it  here: https://github.com/WayneD/rsync/commit/5dcb49c7ddec765d4a24b4f801ffc7212c085db1

:-)
Comment 3 Larry the Git Cow gentoo-dev 2020-07-28 06:54:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0c6c276cbc2bc2b5eb25264586b2a5fef1af3c2

commit f0c6c276cbc2bc2b5eb25264586b2a5fef1af3c2
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-07-28 06:54:11 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-07-28 06:54:47 +0000

    net-misc/rsync: Revbump to backport two fixes
    
    - Allow --bwlimit=0 again
    - Fix usage of zstd compression
    
    Closes: https://bugs.gentoo.org/731306
    Closes: https://bugs.gentoo.org/733084
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../rsync/files/rsync-3.2.2-allow_bwlimit_0.patch  |  77 ++++++++++
 .../rsync/files/rsync-3.2.2-zstd_see_token.patch   |  31 ++++
 net-misc/rsync/rsync-3.2.2-r1.ebuild               | 158 +++++++++++++++++++++
 3 files changed, 266 insertions(+)