https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-mail/fdm fails to compile. Discovered on: amd64 NOTE: This machine uses a clang/LLVM toolchain. If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue isstrictly related to the LLD linker, please block bug 731004.
Created attachment 648228 [details] build.log build log and emerge --info
Simple fix. I think AC_CHECK_DECL is just always wrong. I read through OpenSSH and it was using AC_CHECK_FUNCS for these. diff -ru fdm-2.0.orig/configure.ac fdm-2.0/configure.ac --- fdm-2.0.orig/configure.ac 2021-01-08 20:43:47.007041684 -0800 +++ fdm-2.0/configure.ac 2021-01-08 20:43:57.385042347 -0800 @@ -107,13 +107,13 @@ AC_MSG_ERROR("libssl not found") fi -AC_CHECK_DECL(strlcpy, found_strlcpy=yes, found_strlcpy=no) +AC_CHECK_FUNC(strlcpy, found_strlcpy=yes, found_strlcpy=no) if test "x$found_strlcpy" = xyes; then AC_DEFINE(HAVE_STRLCPY) fi AM_CONDITIONAL(NO_STRLCPY, [test "x$found_strlcpy" = xno]) -AC_CHECK_DECL(strlcat, found_strlcat=yes, found_strlcat=no) +AC_CHECK_FUNC(strlcat, found_strlcat=yes, found_strlcat=no) if test "x$found_strlcat" = xyes; then AC_DEFINE(HAVE_STRLCAT) fi
tinderbox has reproduced this issue with version 2.0-r1 - Updating summary.
This is still an issue in 2.2. My fix from 26 months ago still works. I don't know how I'm supposed to feel about running into this problem after all this time and finding my own bug report.
Also, I don't think it's accurate to say this is related to lld at all (bug 731004). The conftest doesn't link with AC_CHECK_DECL, it just compiles; it prints warnings, but it compiles.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c56bfb9f4f4b728f0d9e47f1aac0be355ad5e1b3 commit c56bfb9f4f4b728f0d9e47f1aac0be355ad5e1b3 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-03-18 21:54:02 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-03-18 21:54:38 +0000 net-mail/fdm: fix configure w/ clang 16, fix strlcpy check Closes: https://bugs.gentoo.org/731262 Thanks-to: Markus Peloquin <markus@cs.wisc.edu> Signed-off-by: Sam James <sam@gentoo.org> net-mail/fdm/{fdm-2.2.ebuild => fdm-2.2-r1.ebuild} | 8 ++++++++ net-mail/fdm/files/fdm-2.2-configure-strlcpy.patch | 20 ++++++++++++++++++++ 2 files changed, 28 insertions(+)
Thanks, Sam!
(In reply to Markus Peloquin from comment #7) > Thanks, Sam! No worries & I'm sorry for the silly wait. Cheers!
