Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730740 - x11-misc/j4-dmenu-desktop should not depend on x11-misc/dmenu
Summary: x11-misc/j4-dmenu-desktop should not depend on x11-misc/dmenu
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-04 16:58 UTC by Yaroslav Isakov
Modified: 2020-08-23 18:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Isakov 2020-07-04 16:58:41 UTC
Hello! I'm trying to get rid of X11 on my system, and one of the blockers is hard dependency on dmenu (which is X11-only) from j4-dmenu-desktop. Could this requirement be lifted, as j4-dmenu-desktop could use any dmenu replacement (I'm using bemenu with wayland backend, for example)?
Comment 1 Conrad Kostecki gentoo-dev 2020-07-07 18:39:31 UTC
Hi! I think, we can move that into an optfeature.
How does bemenu work with x11-misc/j4-dmenu-desktop? Do you need to configure something?
Comment 2 Yaroslav Isakov 2020-07-07 21:30:34 UTC
My proposal is to have a use-flag, dmenu, (enabled by default), or no-dmenu (disabled by default), as j4-dmenu-desktop without any config uses dmenu. But if someone (like me) would want to drop dmenu, he could use this use-flag, and run j4-dmenu-desktop --dmenu="bemenu -i --fn 'DejaVu Sans Mono 13'"
Comment 3 Conrad Kostecki gentoo-dev 2020-08-09 18:40:31 UTC
Hi! I am sorry, that my answer took such long. I was most of the time on vacation ;-) Are you aware, if there are other alternatives among dmenu and bemenu?
Comment 4 Conrad Kostecki gentoo-dev 2020-08-09 18:50:19 UTC
(In reply to Conrad Kostecki from comment #3)
> Hi! I am sorry, that my answer took such long. I was most of the time on
> vacation ;-) Are you aware, if there are other alternatives among dmenu and
> bemenu?

Otherwise, I would introduce a new use flag "wayland", which based on choose either uses dmenu (non wayland) or bemenu (wayland).
Comment 5 Yaroslav Isakov 2020-08-09 20:14:26 UTC
No, I'm not aware of any alternatives. BTW, bemenu also could work on X11, so it's not quite wayland-only dep :)
Comment 6 Yaroslav Isakov 2020-08-09 20:17:29 UTC
Also, the flag will not guarantee that j3-dmenu-desktop will use bemenu, as it has to be specified with flag --dmenu... I think, it would be better to depend on || (dmenu, bemenu), so if bemenu is installed, than it means that user know what to do with it :) And by default, dmenu will be used, still
Comment 7 Conrad Kostecki gentoo-dev 2020-08-19 18:59:24 UTC
Okay, I thought about that one. Are you fine, if I will introduce a dmenu use flag, which will be by default on, since it's configured as default for it. If you disable USE="dmenu", it won't be pulled in.
Comment 8 Yaroslav Isakov 2020-08-22 15:03:23 UTC
Yeah, I think, it will work too.
Comment 9 Larry the Git Cow gentoo-dev 2020-08-23 18:14:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f833556e2489f8610f7a463fdfe51f4729c62d7

commit 8f833556e2489f8610f7a463fdfe51f4729c62d7
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-08-23 16:45:45 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-08-23 17:21:43 +0000

    x11-misc/j4-dmenu-desktop: make dmenu optional
    
    Since x11-misc/j4-dmenu-desktop uses dmenu as default,
    it's being installed as a dependency by default too.
    
    But there are also pure wayland users, but dmenu can't be used on wayland.
    As x11-misc/j4-dmenu-desktop is flexible, users can manually configure
    a dmenu alternative, like dev-libs/bemenu.
    
    The possibility of disabling dmenu also won't pull in any X11
    dependencies from x11-misc/dmenu anymore.
    
    Also migrated from cmake-utils to cmake.
    
    Closes: https://bugs.gentoo.org/730740
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../j4-dmenu-desktop-2.17-r1.ebuild                | 56 ++++++++++++++++++++++
 x11-misc/j4-dmenu-desktop/metadata.xml             |  3 ++
 2 files changed, 59 insertions(+)