Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730550 - gui-wm/hikari should not even conditionally depend on app-text/pandoc
Summary: gui-wm/hikari should not even conditionally depend on app-text/pandoc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aisha Tammy
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-03 10:06 UTC by Gabriel
Modified: 2020-08-15 09:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove man USE flag and pandoc dependency from hikari ebuild (remove.pandoc.diff,894 bytes, patch)
2020-07-03 10:06 UTC, Gabriel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel 2020-07-03 10:06:40 UTC
Created attachment 647470 [details, diff]
Remove man USE flag and pandoc dependency from hikari ebuild

hikari uses the USE flag "man" to build its manpages, for which is requires pandoc (and all haskell masked dependencies).

In practice, pandoc is never utilised, as hikari already ships the generated man pages. See build.log - "make: Nothing to be done for 'doc'."

It is possible to remove said USE flag and pandoc dependency.
Attached a diff with an ebuild I tested locally (2.0.4).

Apologies if I missed something obvious, as I don't really work with ebuilds :)
Comment 1 Aisha Tammy 2020-07-03 12:26:11 UTC
Oh, a very interesting point.

I'll fix up the ebuild for the next release, I am waiting for 2.1.0 instead of doing weekly updates for hikari.
Comment 2 Gabriel 2020-07-03 20:20:39 UTC
Aisha, thanks for looking into this. And needless to say take your time - agree that waiting for next major-ish release makes sense (unless there's a massive bug we don't know about).
Comment 3 Larry the Git Cow gentoo-dev 2020-08-15 09:29:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f7fbfed5e0f9ad844125666159b8e9ec85159c31

commit f7fbfed5e0f9ad844125666159b8e9ec85159c31
Author:     Aisha Tammy <gentoo@aisha.cc>
AuthorDate: 2020-08-04 13:20:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-08-15 09:29:47 +0000

    gui-wm/hikari: update to version 2.1.1
    
    Closes: https://bugs.gentoo.org/733646
    Closes: https://bugs.gentoo.org/730550
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Aisha Tammy <gentoo@aisha.cc>
    Closes: https://github.com/gentoo/gentoo/pull/16999
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 gui-wm/hikari/Manifest                          |   1 +
 gui-wm/hikari/files/hikari-2.1.1-gnu-make.patch | 332 ++++++++++++++++++++++++
 gui-wm/hikari/hikari-2.1.1.ebuild               |  57 ++++
 gui-wm/hikari/metadata.xml                      |   1 +
 4 files changed, 391 insertions(+)