Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730520 - media-libs/openh264-2.1.1 - make: nasm: Command not found
Summary: media-libs/openh264-2.1.1 - make: nasm: Command not found
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Stakenvicius (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-03 03:22 UTC by David Michael
Modified: 2020-07-03 16:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-07-03 03:22:31 UTC
The build system defaults to USE_ASM=Yes which causes x86 assembly definitions to be included, which makes other architectures explode.  I verified it fails on arm, ppc, and riscv.

Also, it calls "ar" directly, so the AR environment should be set along with the compilers to fix it.

Reproducible: Always

Steps to Reproduce:
1. emerge -v =media-libs/openh264-2.1.1  # with a cross-compiling profile

Actual Results:  
See the log.  If nasm wasn't installed, it also fails with this:
nasm -DX86_32 -f elf -I./codec/common/x86/   -o codec/common/x86/cpuid.o codec/common/x86/cpuid.asm
make: nasm: Command not found

Expected Results:  
It should build and install.

I tested fixing it with EXTRA_EMAKE=USE_ASM=No and AR set in the environment.
Comment 1 David Michael 2020-07-03 03:26:00 UTC
Okay, nevermind about the log.  Bugzilla is on fire with "Malformed multipart POST: data truncated" errors when uploading.
Comment 2 Larry the Git Cow gentoo-dev 2020-07-03 16:15:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c614ff3eadeaac60d0f62d34b1f21db3869fceb

commit 2c614ff3eadeaac60d0f62d34b1f21db3869fceb
Author:     Stephan Hartmann <stha09@googlemail.com>
AuthorDate: 2020-07-03 14:07:22 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-07-03 16:15:21 +0000

    media-libs/openh264: fix cross compiling
    
    Closes: https://bugs.gentoo.org/730520
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Stephan Hartmann <stha09@googlemail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16571
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 media-libs/openh264/openh264-2.1.1.ebuild | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)