$ . /lib/gentoo/functions.sh $ einfo "test%test" * test0,000000e+00st $ einfo "test%PYTHON_USEDEP%" bash: printf: `P': invalid format character * test
FTFY
Created attachment 647584 [details, diff] Refactor printf calls
Created attachment 647586 [details, diff] Refactor printf calls v2
You probably want %b, as it's supposed to handle escapes.
(In reply to Michał Górny from comment #4) > You probably want %b, as it's supposed to handle escapes. Yeah, that makes sense. This might also be a good opportunity to make the behavior more closely match Portage's implementation.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=ce648e7539607a1809a1e4a037ade84bb4cde7b2 commit ce648e7539607a1809a1e4a037ade84bb4cde7b2 Author: Kerin Millar <kfm@plushkava.net> AuthorDate: 2023-02-15 07:35:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-15 07:43:55 +0000 Do not use %b to decode user-supplied message strings For a long time, user-supplied message strings were injected into format strings used by printf. Obviously, doing so was a bad thing because it would cause printf to interpret any escape sequences and format specifiers that might be present in the string. The issue of specifier injection was dealt with by the introduction of _eprint(). This commit deals with the remaining issue by eliminating the use of %b, whose only effect was to needlessly try to decode the message string according to the same rules as echo -e (for XSI-conformant systems). Signed-off-by: Kerin Millar <kfm@plushkava.net> Bug: https://bugs.gentoo.org/730432 Signed-off-by: Sam James <sam@gentoo.org> functions.sh | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=34abe2307694673a704009d3baf8862008711fab commit 34abe2307694673a704009d3baf8862008711fab Author: Kerin Millar <kfm@plushkava.net> AuthorDate: 2023-02-15 05:03:42 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-15 07:32:35 +0000 Implement - and integrate - an _eprint() helper function The _eprint() function encapsulates some of the behaviour that the following functions have in common. - ebegin - einfo - einfon - eerror - eerrorn - ewarnn - ewarn Additionally, have einfo() wrap einfon(), eerror() wrap eerrorn(), and ewarn() wrap ewarnn(). All of this allows for a pleasing degree of code reduction while improving the structure of the functions overall, partly owing to a complementary reduction in the number of return statements. It also plots a course for the eventual implementation of proper TTY detection, in a context-sensitive manner. Bug: https://bugs.gentoo.org/730432 Signed-off-by: Kerin Millar <kfm@plushkava.net> Signed-off-by: Sam James <sam@gentoo.org> functions.sh | 109 ++++++++++++++++++++--------------------------------------- 1 file changed, 37 insertions(+), 72 deletions(-)
