Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730420 - net-news/newsboat-2.13 with dev-libs/json-c-0.14 - src/newsblur_api.cpp:168:63: error: ‘FALSE’ was not declared in this scope
Summary: net-news/newsboat-2.13 with dev-libs/json-c-0.14 - src/newsblur_api.cpp:168:6...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: CVE-2020-12762
  Show dependency tree
 
Reported: 2020-07-01 21:37 UTC by David Denoncin
Modified: 2020-08-01 19:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
git format patch for net-news/newsboat-2.13 (0001-net-news-newsboat-fix-dependency-on-json-c.patch,1.00 KB, patch)
2020-07-01 21:37 UTC, David Denoncin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Denoncin 2020-07-01 21:37:38 UTC
Created attachment 647338 [details, diff]
git format patch for net-news/newsboat-2.13

See https://github.com/newsboat/newsboat/issues/1014. The ebuild should depend on a version on json-c that is before 0.13.

Attached is patch that worked for me.
Comment 1 Ionen Wolkens gentoo-dev 2020-07-02 13:57:52 UTC
While there's 2.19-r1 that works, received the json-c fix, and could be stabilized... it would be nice for 2.13 to be patched and kept around for a while still.

2.19-r1 needs dev-lang/rust and dev-lang/ruby (through asciidoctor) as new dependencies which is rather heavy.

Then again 2.13 is almost 2 years old and I wouldn't be surprised if it is a security risk (malformed rss reading and the like could come to mind, not that I've heard any confirmation of such existing).
Comment 2 David Denoncin 2020-07-05 15:51:10 UTC
I'm making a PR applying the 2.19 patch that I've tested on my machine.
Comment 3 Larry the Git Cow gentoo-dev 2020-08-01 19:10:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ca902514c95ccfdd8f0f14fc53b6c10e01fdd0c

commit 8ca902514c95ccfdd8f0f14fc53b6c10e01fdd0c
Author:     David Denoncin <ddenoncin@gmail.com>
AuthorDate: 2020-07-01 21:34:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-08-01 07:07:39 +0000

    net-news/newsboat: apply json-c-0.14 fix
    
    Closes: https://bugs.gentoo.org/730420
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: David Denoncin <ddenoncin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16601
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/newsboat-2.13-json-c-0.14.0.patch        | 37 ++++++++++++++++++++++
 net-news/newsboat/newsboat-2.13.ebuild             |  3 +-
 2 files changed, 39 insertions(+), 1 deletion(-)