Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730306 - dev-python/importlib_metadata-1.7.0: incorrect removal of setuptools_scm dependency
Summary: dev-python/importlib_metadata-1.7.0: incorrect removal of setuptools_scm depe...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Louis Sautier (sbraz)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-01 06:49 UTC by Agostino Sarubbo
Modified: 2020-07-03 09:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,9.97 KB, text/plain)
2020-07-01 06:49 UTC, Agostino Sarubbo
Details
example (example.txt,15.07 KB, text/plain)
2020-07-03 09:43 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-07-01 06:49:37 UTC
@@This is an auto-filed bug@@
Feel free to change the summary at your convenience.

Issue: dev-python/vdf fails tests.
Discovered on: amd64

NOTE:
If you need further logs, feel free to ask.
Comment 1 Agostino Sarubbo gentoo-dev 2020-07-01 06:49:42 UTC
Created attachment 647256 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-07-01 06:53:40 UTC
A similar issue happened multiple times few weeks ago. It was marked as invalid, now I run the test manually and when I merge vdf I have:

$ emerge -avq dev-python/vdf
[binary  N    ] dev-python/backports-1.0  PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8" 
[binary  N    ] dev-python/six-1.15.0  USE="-doc -test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/more-itertools-5.0.0  USE="-doc -test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/py-1.8.0  USE="-doc -test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/backports-functools-lru-cache-1.6.1  USE="-doc -test" PYTHON_TARGETS="python2_7" 
[binary  N    ] dev-python/wcwidth-0.2.5  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/pyparsing-2.4.7  USE="-examples" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/packaging-20.4  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/zipp-1.0.0  USE="-doc -test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8" 
[binary  N    ] dev-python/configparser-3.5.0-r1  PYTHON_TARGETS="python2_7" 
[binary  N    ] dev-python/contextlib2-0.6.0_p1  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/scandir-1.10.0-r1  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -python3_6" 
[binary  N    ] dev-python/pathlib2-2.3.5  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[ebuild  N    ] dev-python/importlib_metadata-1.7.0  USE="-doc -test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8" 
[binary  N    ] dev-python/setuptools_scm-4.1.2  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/namespace-zope-1  PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/pluggy-0.13.1  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/zope-interface-5.1.0  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/attrs-19.3.0  USE="-test" PYTHON_TARGETS="python2_7 python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[binary  N    ] dev-python/pytest-5.4.3  USE="-test" PYTHON_TARGETS="python3_7 -pypy3 -python3_6 -python3_8 -python3_9" 
[ebuild  N    ] dev-python/vdf-3.3  USE="test" PYTHON_TARGETS="python3_7 -pypy3 -python3_6 -python3_8" 


So from python shell I got:

$ python3.7
Python 3.7.8 (default, Jun 29 2020, 23:01:39) 
[GCC 10.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from importlib_metadata import version
>>>

I really don't know why this happens. At the first time I thought there was a problem with binary package but in this case it is merged from source.
Comment 3 Marek Szuba archtester gentoo-dev 2020-07-01 08:08:44 UTC
Reassinging this because seeing as the problem occurs in pytest itself, there doesn't seem to be anything I could do in vdf to work around it even if I could reproduce this problem on my end.
Comment 4 Marek Szuba archtester gentoo-dev 2020-07-03 09:32:28 UTC
ago and I have looked at this some more and the problem is, the sed line in python_prepare_all() which is supposed to replace "use_scm_version=True" with "version='1.7.0'" in setup.py does not do anything. If I see correctly, it's because there is a comma in the match pattern which does not appear in the 1.7.0 setup.py (use_scm_version is the only argument).

This means there are two problems:

1. The match does not work,
2. In spite of this sed does not return a non-zero exit code.
Comment 5 Agostino Sarubbo gentoo-dev 2020-07-03 09:43:15 UTC
Created attachment 647454 [details]
example

This is how I can reproduce
Comment 6 Larry the Git Cow gentoo-dev 2020-07-03 09:58:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5658ee595d9f3478adf9697984bcea661e3d7d1

commit a5658ee595d9f3478adf9697984bcea661e3d7d1
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-07-03 09:58:16 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-07-03 09:58:53 +0000

    dev-python/importlib_metadata: Restore dep on setuptools_scm
    
    Closes: https://bugs.gentoo.org/730306
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 ...rtlib_metadata-1.7.0.ebuild => importlib_metadata-1.7.0-r1.ebuild} | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)